btrfs: fix referenced/exclusive check in squota_check_parent_usage()

boryas · kdave · commit 2ab22446425c · 2026-02-26T15:03:27.000+01:00
We compared rfer_cmpr against excl_cmpr_sum instead of rfer_cmpr_sum which is confusing. I expect that rfer_cmpr == excl_cmpr in squota, but it is much better to be consistent in case of any surprises or bugs. Reported-by: Chris Mason <clm@meta.com> Link: https://lore.kernel.org/linux-btrfs/cover.1764796022.git.boris@bur.io/T/#mccb231643ffd290b44a010d4419474d280be5537 Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Boris Burkov <boris@bur.io> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
@@ -370,7 +370,7 @@ static bool squota_check_parent_usage(struct btrfs_fs_info *fs_info, struct btrf
 		nr_members++;
 	}
 	mismatch = (parent->excl != excl_sum || parent->rfer != rfer_sum ||
-		    parent->excl_cmpr != excl_cmpr_sum || parent->rfer_cmpr != excl_cmpr_sum);
+		    parent->excl_cmpr != excl_cmpr_sum || parent->rfer_cmpr != rfer_cmpr_sum);
 
 	WARN(mismatch,
 	     "parent squota qgroup %hu/%llu has mismatched usage from its %d members. "

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ static bool squota_check_parent_usage(struct btrfs_fs_info *fs_info, struct btrf`
`370`	`370`	`nr_members++;`
`371`	`371`	`}`
`372`	`372`	`mismatch = (parent->excl != excl_sum \|\| parent->rfer != rfer_sum \|\|`
`373`		`- parent->excl_cmpr != excl_cmpr_sum \|\| parent->rfer_cmpr != excl_cmpr_sum);`
	`373`	`+ parent->excl_cmpr != excl_cmpr_sum \|\| parent->rfer_cmpr != rfer_cmpr_sum);`
`374`	`374`
`375`	`375`	`WARN(mismatch,`
`376`	`376`	`"parent squota qgroup %hu/%llu has mismatched usage from its %d members. "`