Skip to content

Commit 29d1f56

Browse files
committed
Revert "arm64: dts: rockchip: Further describe the WiFi for the Pinebook Pro"
This reverts commit 6d54d93. It seems there are different variants of the Wifi chipset in use on the Pinebook Pro. And according to the reported regression - see Closes below, the reverted change causes issues with one Wifi chipset. The original commit message indicates a "further description" only and does not indicate this would fix an actual problem, so a revert should not cause further problems. Fixes: 6d54d93 ("arm64: dts: rockchip: Further describe the WiFi for the Pinebook Pro") Cc: Jan Palus <jpalus@fastmail.com> Cc: Peter Robinson <pbrobinson@gmail.com> Cc: Thorsten Leemhuis <regressions@leemhuis.info> Cc: stable@vger.kernel.org Closes: https://lore.kernel.org/r/aUKOlj-RvTYlrpiS@rock.grzadka/ Tested-by: Jan Palus <jpalus@fastmail.com> Reviewed-by: Dragan Simic <dsimic@manjaro.org> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://patch.msgid.link/20260210120142.698512-1-heiko@sntech.de Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 6de23f8 commit 29d1f56

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -879,12 +879,6 @@
879879
};
880880
};
881881

882-
wifi {
883-
wifi_host_wake_l: wifi-host-wake-l {
884-
rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
885-
};
886-
};
887-
888882
wireless-bluetooth {
889883
bt_wake_pin: bt-wake-pin {
890884
rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -942,19 +936,7 @@
942936
pinctrl-names = "default";
943937
pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>;
944938
sd-uhs-sdr104;
945-
#address-cells = <1>;
946-
#size-cells = <0>;
947939
status = "okay";
948-
949-
brcmf: wifi@1 {
950-
compatible = "brcm,bcm4329-fmac";
951-
reg = <1>;
952-
interrupt-parent = <&gpio0>;
953-
interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>;
954-
interrupt-names = "host-wake";
955-
pinctrl-names = "default";
956-
pinctrl-0 = <&wifi_host_wake_l>;
957-
};
958940
};
959941

960942
&sdhci {

0 commit comments

Comments
 (0)