Skip to content

Commit 24e7625

Browse files
aloktiwaandersson
authored andcommitted
soc: qcom: llcc: fix v1 SB syndrome register offset
The llcc_v1_edac_reg_offset table uses 0x2304c for trp_ecc_sb_err_syn0, which is inconsistent with the surrounding TRP ECC registers (0x2034x) and with llcc_v2_1_edac_reg_offset, where trp_ecc_sb_err_syn0 is 0x2034c adjacent to trp_ecc_error_status0/1 at 0x20344/0x20348. Use 0x2034c for llcc v1 so the SB syndrome register follows the expected +0x4 progression from trp_ecc_error_status1. This fixes EDAC reading the wrong register for SB syndrome reporting. Fixes: c13d7d2 ("soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/r/20260330095118.2657362-1-alok.a.tiwari@oracle.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent dc67808 commit 24e7625

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/soc/qcom/llcc-qcom.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4030,7 +4030,7 @@ static const struct llcc_slice_config x1e80100_data[] = {
40304030
static const struct llcc_edac_reg_offset llcc_v1_edac_reg_offset = {
40314031
.trp_ecc_error_status0 = 0x20344,
40324032
.trp_ecc_error_status1 = 0x20348,
4033-
.trp_ecc_sb_err_syn0 = 0x2304c,
4033+
.trp_ecc_sb_err_syn0 = 0x2034c,
40344034
.trp_ecc_db_err_syn0 = 0x20370,
40354035
.trp_ecc_error_cntr_clear = 0x20440,
40364036
.trp_interrupt_0_status = 0x20480,

0 commit comments

Comments
 (0)