Skip to content

Commit 20adbf3

Browse files
Bartosz GolaszewskipH5
authored andcommitted
reset: warn on reset-gpio release
While we implement an empty .release() callback for reset-gpio (driver core requires it), this function will never actually be called as nobody ever removes the device and the last reference is not dropped anywhere. This is by design - once created, the reset-gpio device stays in memory. Make the .release() callback emit a warning, should it ever be called due to a programming bug. Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
1 parent 1acd466 commit 20adbf3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/reset/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ static void __reset_control_put_internal(struct reset_control *rstc)
820820

821821
static void reset_gpio_aux_device_release(struct device *dev)
822822
{
823-
823+
WARN(1, "reset-gpio device %s should never have been removed", dev_name(dev));
824824
}
825825

826826
static int reset_create_gpio_aux_device(struct reset_gpio_lookup *rgpio_dev,

0 commit comments

Comments
 (0)