Skip to content

Commit 2018e29

Browse files
committed
drm/i915/dp: Fail state computation for invalid min/max link BPP values
Make sure that state computation fails if the minimum/maximum link BPP values got invalid as a result of limiting both of these values separately to the corresponding source/sink capability limits. Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> Reviewed-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patch.msgid.link/20251215192357.172201-14-imre.deak@intel.com
1 parent 3755e20 commit 2018e29

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2646,16 +2646,21 @@ intel_dp_compute_config_link_bpp_limits(struct intel_dp *intel_dp,
26462646
limits->link.max_bpp_x16 = max_link_bpp_x16;
26472647

26482648
drm_dbg_kms(display->drm,
2649-
"[ENCODER:%d:%s][CRTC:%d:%s] DP link limits: pixel clock %d kHz DSC %s max lanes %d max rate %d max pipe_bpp %d max link_bpp " FXP_Q4_FMT "\n",
2649+
"[ENCODER:%d:%s][CRTC:%d:%s] DP link limits: pixel clock %d kHz DSC %s max lanes %d max rate %d max pipe_bpp %d min link_bpp " FXP_Q4_FMT " max link_bpp " FXP_Q4_FMT "\n",
26502650
encoder->base.base.id, encoder->base.name,
26512651
crtc->base.base.id, crtc->base.name,
26522652
adjusted_mode->crtc_clock,
26532653
str_on_off(dsc),
26542654
limits->max_lane_count,
26552655
limits->max_rate,
26562656
limits->pipe.max_bpp,
2657+
FXP_Q4_ARGS(limits->link.min_bpp_x16),
26572658
FXP_Q4_ARGS(limits->link.max_bpp_x16));
26582659

2660+
if (limits->link.min_bpp_x16 <= 0 ||
2661+
limits->link.min_bpp_x16 > limits->link.max_bpp_x16)
2662+
return false;
2663+
26592664
return true;
26602665
}
26612666

0 commit comments

Comments
 (0)