Skip to content

Commit 1777f34

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: check removing signal+subflow endp
This validates the previous commit: endpoints with both the signal and subflow flags should always be marked as used even if it was not possible to create new subflows due to the MPTCP PM limits. For this test, an extra endpoint is created with both the signal and the subflow flags, and limits are set not to create extra subflows. In this case, an ADD_ADDR is sent, but no subflows are created. Still, the local endpoint is marked as used, and no warning is fired when removing the endpoint, after having sent a RM_ADDR. The 'Fixes' tag here below is the same as the one from the previous commit: this patch here is not fixing anything wrong in the selftests, but it validates the previous fix for an issue introduced by this commit ID. Fixes: 85df533 ("mptcp: pm: do not ignore 'subflow' if 'signal' flag is also set") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20260303-net-mptcp-misc-fixes-7-0-rc2-v1-5-4b5462b6f016@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 579a752 commit 1777f34

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2626,6 +2626,19 @@ remove_tests()
26262626
chk_rst_nr 0 0
26272627
fi
26282628

2629+
# signal+subflow with limits, remove
2630+
if reset "remove signal+subflow with limits"; then
2631+
pm_nl_set_limits $ns1 0 0
2632+
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal,subflow
2633+
pm_nl_set_limits $ns2 0 0
2634+
addr_nr_ns1=-1 speed=slow \
2635+
run_tests $ns1 $ns2 10.0.1.1
2636+
chk_join_nr 0 0 0
2637+
chk_add_nr 1 1
2638+
chk_rm_nr 1 0 invert
2639+
chk_rst_nr 0 0
2640+
fi
2641+
26292642
# addresses remove
26302643
if reset "remove addresses"; then
26312644
pm_nl_set_limits $ns1 3 3

0 commit comments

Comments
 (0)