Skip to content

Commit 1489a34

Browse files
ionutnechitaJiri Kosina
authored andcommitted
HID: asus: Implement Fn+F5 fan control key handler
On Asus ROG laptops, the Fn+F5 key (HID code 0xae) is used to cycle through fan modes. This key press needs to be forwarded to the asus-wmi driver to actually change the fan mode. Add ASUS_FAN_CTRL_KEY_CODE define and implement the handler in asus_raw_event() to send WMI events when this key is pressed. When asus-wmi successfully handles the event, it is blocked from reaching userspace. If asus-wmi is unavailable or fails, the event is passed to userspace via evdev, allowing userspace implementations of fan control. Tested on Asus ROG G14/G15 series laptops. Reviewed-by: Denis Benato <benato.denis96@gmail.com> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org> Signed-off-by: Ionut Nechita <ionut_n2001@yahoo.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent c888d0b commit 1489a34

1 file changed

Lines changed: 30 additions & 5 deletions

File tree

drivers/hid/hid-asus.c

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
6464
#define ASUS_SPURIOUS_CODE_0X8A 0x8a
6565
#define ASUS_SPURIOUS_CODE_0X9E 0x9e
6666

67+
/* Special key codes */
68+
#define ASUS_FAN_CTRL_KEY_CODE 0xae
69+
6770
#define SUPPORT_KBD_BACKLIGHT BIT(0)
6871

6972
#define MAX_TOUCH_MAJOR 8
@@ -378,12 +381,34 @@ static int asus_raw_event(struct hid_device *hdev,
378381
if (report->id == FEATURE_KBD_LED_REPORT_ID1 || report->id == FEATURE_KBD_LED_REPORT_ID2)
379382
return -1;
380383
if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
381-
/*
382-
* ASUS ROG laptops send these codes during normal operation
383-
* with no discernable reason. Filter them out to avoid
384-
* unmapped warning messages.
385-
*/
386384
if (report->id == FEATURE_KBD_REPORT_ID) {
385+
/*
386+
* Fn+F5 fan control key - try to send WMI event to toggle fan mode.
387+
* If successful, block the event from reaching userspace.
388+
* If asus-wmi is unavailable or the call fails, let the event
389+
* pass to userspace so it can implement its own fan control.
390+
*/
391+
if (data[1] == ASUS_FAN_CTRL_KEY_CODE) {
392+
int ret = asus_wmi_send_event(drvdata, ASUS_FAN_CTRL_KEY_CODE);
393+
394+
if (ret == 0) {
395+
/* Successfully handled by asus-wmi, block event */
396+
return -1;
397+
}
398+
399+
/*
400+
* Warn if asus-wmi failed (but not if it's unavailable).
401+
* Let the event reach userspace in all failure cases.
402+
*/
403+
if (ret != -ENODEV)
404+
hid_warn(hdev, "Failed to notify asus-wmi: %d\n", ret);
405+
}
406+
407+
/*
408+
* ASUS ROG laptops send these codes during normal operation
409+
* with no discernable reason. Filter them out to avoid
410+
* unmapped warning messages.
411+
*/
387412
if (data[1] == ASUS_SPURIOUS_CODE_0XEA ||
388413
data[1] == ASUS_SPURIOUS_CODE_0XEC ||
389414
data[1] == ASUS_SPURIOUS_CODE_0X02 ||

0 commit comments

Comments
 (0)