Skip to content

Commit 122d16d

Browse files
DispatchCodecminyard
authored andcommitted
ipmi: Replace use of system_wq with system_percpu_wq
This patch continues the effort to refactor workqueue APIs, which has begun with the changes introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") The point of the refactoring is to eventually alter the default behavior of workqueues to become unbound by default so that their workload placement is optimized by the scheduler. Before that to happen after a careful review and conversion of each individual case, workqueue users must be converted to the better named new workqueues with no intended behaviour changes: system_wq -> system_percpu_wq system_unbound_wq -> system_dfl_wq This way the old obsolete workqueues (system_wq, system_unbound_wq) can be removed in the future. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Message-ID: <20251224161301.135382-1-marco.crivellari@suse.com> Signed-off-by: Corey Minyard <corey@minyard.net>
1 parent af4e9ef commit 122d16d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/char/ipmi/ipmi_msghandler.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -987,7 +987,7 @@ static int deliver_response(struct ipmi_smi *intf, struct ipmi_recv_msg *msg)
987987
mutex_lock(&intf->user_msgs_mutex);
988988
list_add_tail(&msg->link, &intf->user_msgs);
989989
mutex_unlock(&intf->user_msgs_mutex);
990-
queue_work(system_wq, &intf->smi_work);
990+
queue_work(system_percpu_wq, &intf->smi_work);
991991
}
992992

993993
return rv;
@@ -4977,7 +4977,7 @@ void ipmi_smi_msg_received(struct ipmi_smi *intf,
49774977
if (run_to_completion)
49784978
smi_work(&intf->smi_work);
49794979
else
4980-
queue_work(system_wq, &intf->smi_work);
4980+
queue_work(system_percpu_wq, &intf->smi_work);
49814981
}
49824982
EXPORT_SYMBOL(ipmi_smi_msg_received);
49834983

@@ -4987,7 +4987,7 @@ void ipmi_smi_watchdog_pretimeout(struct ipmi_smi *intf)
49874987
return;
49884988

49894989
atomic_set(&intf->watchdog_pretimeouts_to_deliver, 1);
4990-
queue_work(system_wq, &intf->smi_work);
4990+
queue_work(system_percpu_wq, &intf->smi_work);
49914991
}
49924992
EXPORT_SYMBOL(ipmi_smi_watchdog_pretimeout);
49934993

@@ -5162,7 +5162,7 @@ static bool ipmi_timeout_handler(struct ipmi_smi *intf,
51625162
flags);
51635163
}
51645164

5165-
queue_work(system_wq, &intf->smi_work);
5165+
queue_work(system_percpu_wq, &intf->smi_work);
51665166

51675167
return need_timer;
51685168
}
@@ -5218,7 +5218,7 @@ static void ipmi_timeout(struct timer_list *unused)
52185218
if (atomic_read(&stop_operation))
52195219
return;
52205220

5221-
queue_work(system_wq, &ipmi_timer_work);
5221+
queue_work(system_percpu_wq, &ipmi_timer_work);
52225222
}
52235223

52245224
static void need_waiter(struct ipmi_smi *intf)

0 commit comments

Comments
 (0)