Skip to content

Commit 0e211f6

Browse files
Sanman Pradhangroeck
authored andcommitted
hwmon: (tps53679) Fix array access with zero-length block read
i2c_smbus_read_block_data() can return 0, indicating a zero-length read. When this happens, tps53679_identify_chip() accesses buf[ret - 1] which is buf[-1], reading one byte before the buffer on the stack. Fix by changing the check from "ret < 0" to "ret <= 0", treating a zero-length read as an error (-EIO), which prevents the out-of-bounds array access. Also fix a typo in the adjacent comment: "if present" instead of duplicate "if". Fixes: 75ca1e5 ("hwmon: (pmbus/tps53679) Add support for TPS53685") Signed-off-by: Sanman Pradhan <psanman@juniper.net> Link: https://lore.kernel.org/r/20260329170925.34581-2-sanman.pradhan@hpe.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 7aaa804 commit 0e211f6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/hwmon/pmbus/tps53679.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ static int tps53679_identify_chip(struct i2c_client *client,
103103
}
104104

105105
ret = i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf);
106-
if (ret < 0)
107-
return ret;
106+
if (ret <= 0)
107+
return ret < 0 ? ret : -EIO;
108108

109-
/* Adjust length if null terminator if present */
109+
/* Adjust length if null terminator is present */
110110
buf_len = (buf[ret - 1] != '\x00' ? ret : ret - 1);
111111

112112
id_len = strlen(id);

0 commit comments

Comments
 (0)