Skip to content

Commit 0d9a60a

Browse files
pavanchebbikuba-moo
authored andcommitted
bnxt_en: Fix RSS table size check when changing ethtool channels
When changing channels, the current check in bnxt_set_channels() is not checking for non-default RSS contexts when the RSS table size changes. The current check for IFF_RXFH_CONFIGURED is only sufficient for the default RSS context. Expand the check to include the presence of any non-default RSS contexts. Allowing such change will result in incorrect configuration of the context's RSS table when the table size changes. Fixes: b3d0083 ("bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()") Reported-by: Björn Töpel <bjorn@kernel.org> Link: https://lore.kernel.org/netdev/20260303181535.2671734-1-bjorn@kernel.org/ Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20260306225854.3575672-1-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 183f682 commit 0d9a60a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -979,8 +979,8 @@ static int bnxt_set_channels(struct net_device *dev,
979979

980980
if (bnxt_get_nr_rss_ctxs(bp, req_rx_rings) !=
981981
bnxt_get_nr_rss_ctxs(bp, bp->rx_nr_rings) &&
982-
netif_is_rxfh_configured(dev)) {
983-
netdev_warn(dev, "RSS table size change required, RSS table entries must be default to proceed\n");
982+
(netif_is_rxfh_configured(dev) || bp->num_rss_ctx)) {
983+
netdev_warn(dev, "RSS table size change required, RSS table entries must be default (with no additional RSS contexts present) to proceed\n");
984984
return -EINVAL;
985985
}
986986

0 commit comments

Comments
 (0)