Skip to content

Commit 0a1fc2f

Browse files
hodgesdskeithbusch
authored andcommitted
nvme-fabrics: use kfree_sensitive() for DHCHAP secrets
The DHCHAP secrets (dhchap_secret and dhchap_ctrl_secret) contain authentication key material for NVMe-oF. Use kfree_sensitive() instead of kfree() in nvmf_free_options() to ensure secrets are zeroed before the memory is freed, preventing recovery from freed pages. Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Daniel Hodges <hodgesd@meta.com> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent ac30cd3 commit 0a1fc2f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/nvme/host/fabrics.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1290,8 +1290,8 @@ void nvmf_free_options(struct nvmf_ctrl_options *opts)
12901290
kfree(opts->subsysnqn);
12911291
kfree(opts->host_traddr);
12921292
kfree(opts->host_iface);
1293-
kfree(opts->dhchap_secret);
1294-
kfree(opts->dhchap_ctrl_secret);
1293+
kfree_sensitive(opts->dhchap_secret);
1294+
kfree_sensitive(opts->dhchap_ctrl_secret);
12951295
kfree(opts);
12961296
}
12971297
EXPORT_SYMBOL_GPL(nvmf_free_options);

0 commit comments

Comments
 (0)