Skip to content

Commit 088a3c9

Browse files
calebsanderkawasaki
authored andcommitted
target: use bio_integrity_intervals() helper
Use bio_integrity_intervals() to convert bio->bi_iter.bi_sector to integrity intervals to reduce code duplication. Make the same change in the nvmet code that appears to have been copied from the target code. Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> Reviewed-by: Anuj Gupta <anuj20.g@samsung.com>
1 parent 312eba2 commit 088a3c9

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/nvme/target/io-cmd-bdev.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,7 @@ static int nvmet_bdev_alloc_bip(struct nvmet_req *req, struct bio *bio,
220220
}
221221

222222
/* virtual start sector must be in integrity interval units */
223-
bip_set_seed(bip, bio->bi_iter.bi_sector >>
224-
(bi->interval_exp - SECTOR_SHIFT));
223+
bip_set_seed(bip, bio_integrity_intervals(bi, bio->bi_iter.bi_sector));
225224

226225
resid = bio_integrity_bytes(bi, bio_sectors(bio));
227226
while (resid > 0 && sg_miter_next(miter)) {

drivers/target/target_core_iblock.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -708,8 +708,7 @@ iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio,
708708
}
709709

710710
/* virtual start sector must be in integrity interval units */
711-
bip_set_seed(bip, bio->bi_iter.bi_sector >>
712-
(bi->interval_exp - SECTOR_SHIFT));
711+
bip_set_seed(bip, bio_integrity_intervals(bi, bio->bi_iter.bi_sector));
713712

714713
pr_debug("IBLOCK BIP Size: %u Sector: %llu\n", bip->bip_iter.bi_size,
715714
(unsigned long long)bip->bip_iter.bi_sector);

0 commit comments

Comments
 (0)