Skip to content

Commit 06c4214

Browse files
Chenghai Huangherbertx
authored andcommitted
crypto: hisilicon - remove unused and non-public APIs for qm and sec
- sec_register_to_crypto() and sec_unregister_from_crypto() have been removed, the function declarations have not been removed. Remove them. - hisi_qm_start_qp and hisi_qm_stop_qp are called internally by the QM. Therefore, the EXPORT_SYMBOL_GPL declaration of these non-public interfaces is deleted. Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent d2b5e8d commit 06c4214

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

drivers/crypto/hisilicon/qm.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,8 @@ static struct qm_typical_qos_table shaper_cbs_s[] = {
472472

473473
static void qm_irqs_unregister(struct hisi_qm *qm);
474474
static int qm_reset_device(struct hisi_qm *qm);
475+
static void hisi_qm_stop_qp(struct hisi_qp *qp);
476+
475477
int hisi_qm_q_num_set(const char *val, const struct kernel_param *kp,
476478
unsigned int device)
477479
{
@@ -2262,7 +2264,7 @@ static int qm_start_qp_nolock(struct hisi_qp *qp, unsigned long arg)
22622264
* After this function, qp can receive request from user. Return 0 if
22632265
* successful, negative error code if failed.
22642266
*/
2265-
int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg)
2267+
static int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg)
22662268
{
22672269
struct hisi_qm *qm = qp->qm;
22682270
int ret;
@@ -2273,7 +2275,6 @@ int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg)
22732275

22742276
return ret;
22752277
}
2276-
EXPORT_SYMBOL_GPL(hisi_qm_start_qp);
22772278

22782279
/**
22792280
* qp_stop_fail_cb() - call request cb.
@@ -2418,13 +2419,12 @@ static void qm_stop_qp_nolock(struct hisi_qp *qp)
24182419
*
24192420
* This function is reverse of hisi_qm_start_qp.
24202421
*/
2421-
void hisi_qm_stop_qp(struct hisi_qp *qp)
2422+
static void hisi_qm_stop_qp(struct hisi_qp *qp)
24222423
{
24232424
down_write(&qp->qm->qps_lock);
24242425
qm_stop_qp_nolock(qp);
24252426
up_write(&qp->qm->qps_lock);
24262427
}
2427-
EXPORT_SYMBOL_GPL(hisi_qm_stop_qp);
24282428

24292429
/**
24302430
* hisi_qp_send() - Queue up a task in the hardware queue.

drivers/crypto/hisilicon/sec2/sec.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,5 @@ enum sec_cap_table_type {
285285

286286
void sec_destroy_qps(struct hisi_qp **qps, int qp_num);
287287
struct hisi_qp **sec_create_qps(void);
288-
int sec_register_to_crypto(struct hisi_qm *qm);
289-
void sec_unregister_from_crypto(struct hisi_qm *qm);
290288
u64 sec_get_alg_bitmap(struct hisi_qm *qm, u32 high, u32 low);
291289
#endif

include/linux/hisi_acc_qm.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,6 @@ int hisi_qm_init(struct hisi_qm *qm);
558558
void hisi_qm_uninit(struct hisi_qm *qm);
559559
int hisi_qm_start(struct hisi_qm *qm);
560560
int hisi_qm_stop(struct hisi_qm *qm, enum qm_stop_reason r);
561-
int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg);
562-
void hisi_qm_stop_qp(struct hisi_qp *qp);
563561
int hisi_qp_send(struct hisi_qp *qp, const void *msg);
564562
void hisi_qm_debug_init(struct hisi_qm *qm);
565563
void hisi_qm_debug_regs_clear(struct hisi_qm *qm);

0 commit comments

Comments
 (0)