HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant

ionutnechita · Jiri Kosina · commit 06501b557fae · 2026-01-08T12:17:16.000+01:00
Use the existing HID_UP_ASUSVENDOR constant instead of the magic number
0xff310000 for better code clarity and maintainability.

Reviewed-by: Denis Benato &lt;benato.denis96@gmail.com&gt;
Reviewed-by: Mario Limonciello (AMD) &lt;superm1@kernel.org&gt;
Signed-off-by: Ionut Nechita &lt;ionut_n2001@yahoo.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
@@ -316,7 +316,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvdat, u8 *data, int size)
 static int asus_event(struct hid_device *hdev, struct hid_field *field,
 		      struct hid_usage *usage, __s32 value)
 {
-	if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 &&
+	if ((usage->hid & HID_USAGE_PAGE) == HID_UP_ASUSVENDOR &&
 	    (usage->hid & HID_USAGE) != 0x00 &&
 	    (usage->hid & HID_USAGE) != 0xff && !usage->type) {
 		hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n",

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ static int asus_e1239t_event(struct asus_drvdata drvdat, u8 data, int size)`
`316`	`316`	`static int asus_event(struct hid_device hdev, struct hid_field field,`
`317`	`317`	`struct hid_usage *usage, __s32 value)`
`318`	`318`	`{`
`319`		`- if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 &&`
	`319`	`+ if ((usage->hid & HID_USAGE_PAGE) == HID_UP_ASUSVENDOR &&`
`320`	`320`	`(usage->hid & HID_USAGE) != 0x00 &&`
`321`	`321`	`(usage->hid & HID_USAGE) != 0xff && !usage->type) {`
`322`	`322`	`hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n",`