Skip to content

Commit 057854f

Browse files
rbmarliererostedt
authored andcommitted
ktest: Avoid undef warning when WARNINGS_FILE is unset
check_buildlog() probes $warnings_file with -f even when WARNINGS_FILE is not configured. Perl warns about the uninitialized value and adds noise to the test log, which can hide the output we actually care about. Check that WARNINGS_FILE is defined before testing whether the file exists. Cc: John Hawley <warthog9@eaglescrag.net> Cc: Andrea Righi <arighi@nvidia.com> Cc: Marcos Paulo de Souza <mpdesouza@suse.com> Cc: Matthieu Baerts <matttbe@kernel.org> Cc: Fernando Fernandez Mancera <fmancera@suse.de> Cc: Pedro Falcato <pfalcato@suse.de> Link: https://patch.msgid.link/20260307-ktest-fixes-v1-1-565d412f4925@suse.com Fixes: 4283b16 ("ktest: Add make_warnings_file and process full warnings") Signed-off-by: Ricardo B. Marlière <rbm@suse.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
1 parent 1f318b9 commit 057854f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/ktest/ktest.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2508,7 +2508,7 @@ sub check_buildlog {
25082508
my $save_no_reboot = $no_reboot;
25092509
$no_reboot = 1;
25102510

2511-
if (-f $warnings_file) {
2511+
if (defined($warnings_file) && -f $warnings_file) {
25122512
open(IN, $warnings_file) or
25132513
dodie "Error opening $warnings_file";
25142514

0 commit comments

Comments
 (0)