Skip to content

Commit 02d58df

Browse files
Charan-Pedumurugregkh
authored andcommitted
dt-bindings: usb: generic-ehci: fix schema structure and add at91sam9g45 constraints
Add clock and phy constraints for atmel,at91sam9g45-ehci and reorganize the allOf section to fix dtbs_check warnings. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com> Link: https://patch.msgid.link/20260327-atmel-usb-v4-3-eb8b6e49b29d@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 73d4839 commit 02d58df

2 files changed

Lines changed: 33 additions & 37 deletions

File tree

Documentation/devicetree/bindings/usb/atmel-usb.txt

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,5 @@
11
Atmel SOC USB controllers
22

3-
EHCI
4-
5-
Required properties:
6-
- compatible: Should be "atmel,at91sam9g45-ehci" for USB controllers
7-
used in host mode.
8-
- reg: Address and length of the register set for the device
9-
- interrupts: Should contain ehci interrupt
10-
- clocks: Should reference the peripheral and the UTMI clocks
11-
- clock-names: Should contain two strings
12-
"ehci_clk" for the peripheral clock
13-
"usb_clk" for the UTMI clock
14-
15-
Optional properties:
16-
- phy_type : For multi port host USB controllers, should be one of
17-
"utmi", or "hsic".
18-
19-
usb1: ehci@800000 {
20-
compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
21-
reg = <0x00800000 0x100000>;
22-
interrupts = <22 4>;
23-
clocks = <&utmi>, <&uhphs_clk>;
24-
clock-names = "usb_clk", "ehci_clk";
25-
};
26-
273
AT91 USB device controller
284

295
Required properties:

Documentation/devicetree/bindings/usb/generic-ehci.yaml

Lines changed: 33 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,6 @@ title: USB EHCI Controller
99
maintainers:
1010
- Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1111

12-
allOf:
13-
- $ref: usb-hcd.yaml
14-
- if:
15-
properties:
16-
compatible:
17-
not:
18-
contains:
19-
const: ibm,usb-ehci-440epx
20-
then:
21-
properties:
22-
reg:
23-
maxItems: 1
24-
2512
properties:
2613
compatible:
2714
oneOf:
@@ -167,6 +154,39 @@ required:
167154
- reg
168155
- interrupts
169156

157+
allOf:
158+
- $ref: usb-hcd.yaml
159+
- if:
160+
properties:
161+
compatible:
162+
not:
163+
contains:
164+
const: ibm,usb-ehci-440epx
165+
then:
166+
properties:
167+
reg:
168+
maxItems: 1
169+
- if:
170+
properties:
171+
compatible:
172+
contains:
173+
const: atmel,at91sam9g45-ehci
174+
then:
175+
properties:
176+
clock-names:
177+
items:
178+
- const: usb_clk
179+
- const: ehci_clk
180+
181+
phy_type:
182+
enum:
183+
- utmi
184+
- hsic
185+
186+
required:
187+
- clocks
188+
- clock-names
189+
170190
unevaluatedProperties: false
171191

172192
examples:

0 commit comments

Comments
 (0)