Skip to content

Commit 01e2809

Browse files
MocLGgregkh
authored andcommitted
staging: rtl8723bs: rename u1bTmp to val
Rename the variable u1bTmp to val to remove Hungarian notation. This improves readability and aligns the code with kernel naming standards. Signed-off-by: Luka Gejak <lukagejak5@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/20260130185658.207785-3-lukagejak5@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7de30d5 commit 01e2809

2 files changed

Lines changed: 22 additions & 22 deletions

File tree

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min_cnt, u32 timeout_ms)
259259
void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
260260
{
261261
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
262-
u8 u1bTmp;
262+
u8 val;
263263
u8 Delay = 100;
264264

265265
if (
@@ -268,19 +268,19 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
268268
/* 0x1cf = 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */
269269
rtw_write8(padapter, REG_HMETFR+3, 0x20);
270270

271-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
272-
while (u1bTmp & BIT2) {
271+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
272+
while (val & BIT2) {
273273
Delay--;
274274
if (Delay == 0)
275275
break;
276276
udelay(50);
277-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
277+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
278278
}
279279

280280
if (Delay == 0) {
281281
/* force firmware reset */
282-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
283-
rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2));
282+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
283+
rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2));
284284
}
285285
}
286286
}

drivers/staging/rtl8723bs/hal/sdio_halinit.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
589589
struct hal_com_data *pHalData;
590590
struct pwrctrl_priv *pwrctrlpriv;
591591
u32 NavUpper = WiFiNavUpperUs;
592-
u8 u1bTmp;
592+
u8 val;
593593

594594
pHalData = GET_HAL_DATA(padapter);
595595
pwrctrlpriv = adapter_to_pwrctl(padapter);
@@ -780,9 +780,9 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
780780
pHalData->SdioTxOQTMaxFreeSpace = pHalData->SdioTxOQTFreeSpace;
781781

782782
/* Enable MACTXEN/MACRXEN block */
783-
u1bTmp = rtw_read8(padapter, REG_CR);
784-
u1bTmp |= (MACTXEN | MACRXEN);
785-
rtw_write8(padapter, REG_CR, u1bTmp);
783+
val = rtw_read8(padapter, REG_CR);
784+
val |= (MACTXEN | MACRXEN);
785+
rtw_write8(padapter, REG_CR, val);
786786

787787
rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper);
788788

@@ -848,34 +848,34 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
848848
/* */
849849
static void CardDisableRTL8723BSdio(struct adapter *padapter)
850850
{
851-
u8 u1bTmp;
851+
u8 val;
852852
u8 bMacPwrCtrlOn;
853853

854854
/* Run LPS WL RFOFF flow */
855855
HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
856856

857857
/* ==== Reset digital sequence ====== */
858858

859-
u1bTmp = rtw_read8(padapter, REG_MCUFWDL);
860-
if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
859+
val = rtw_read8(padapter, REG_MCUFWDL);
860+
if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
861861
rtl8723b_FirmwareSelfReset(padapter);
862862

863863
/* Reset MCU 0x2[10]= 0. Suggested by Filen. 2011.01.26. by tynli. */
864-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN + 1);
865-
u1bTmp &= ~BIT(2); /* 0x2[10], FEN_CPUEN */
866-
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp);
864+
val = rtw_read8(padapter, REG_SYS_FUNC_EN + 1);
865+
val &= ~BIT(2); /* 0x2[10], FEN_CPUEN */
866+
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val);
867867

868868
/* MCUFWDL 0x80[1:0]= 0 */
869869
/* reset MCU ready status */
870870
rtw_write8(padapter, REG_MCUFWDL, 0);
871871

872872
/* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */
873-
u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
874-
u1bTmp &= ~BIT(0);
875-
rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp);
876-
u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
877-
u1bTmp |= BIT(0);
878-
rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp);
873+
val = rtw_read8(padapter, REG_RSV_CTRL + 1);
874+
val &= ~BIT(0);
875+
rtw_write8(padapter, REG_RSV_CTRL + 1, val);
876+
val = rtw_read8(padapter, REG_RSV_CTRL + 1);
877+
val |= BIT(0);
878+
rtw_write8(padapter, REG_RSV_CTRL+1, val);
879879

880880
/* ==== Reset digital sequence end ====== */
881881

0 commit comments

Comments
 (0)