fix: install npm in docker containers

Missing npm has to deal with the underlying debian container, and the
way that the third-party repository sometimes isn't picked up (by my
understanding it has to do with version overlap). The upgrade to the
node major version fixes this issue across both images, while an
explicit `apt-get install npm` works only within the php8 container.

Author: mhitza

Dockerfile.php7

@@ -39,11 +39,12 @@ RUN apt-get update \
   && rm -rf /var/lib/apt/lists/*
 
 
+ENV NODE_MAJOR=20
 # Based on nodesource installation instructions https://github.com/nodesource/distributions#installation-instructions
 RUN mkdir -p /etc/apt/keyrings \
   && curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
   | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
-  && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" > /etc/apt/sources.list.d/nodesource.list \
+  && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" > /etc/apt/sources.list.d/nodesource.list \
   && apt-get update \
   && apt-get install nodejs -y
 

Dockerfile.php8

@@ -39,11 +39,12 @@ RUN apt-get update \
   && rm -rf /var/lib/apt/lists/*
 
 
+ENV NODE_MAJOR=20
 # Based on nodesource installation instructions https://github.com/nodesource/distributions#installation-instructions
 RUN mkdir -p /etc/apt/keyrings \
   && curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
   | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
-  && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" > /etc/apt/sources.list.d/nodesource.list \
+  && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" > /etc/apt/sources.list.d/nodesource.list \
   && apt-get update \
   && apt-get install nodejs -y