From 83b1ea0ecf22745339c89ca506100703cb438e75 Mon Sep 17 00:00:00 2001 From: Jorge Martins <76965647+jfcmartins@users.noreply.github.com> Date: Mon, 9 Nov 2026 10:47:51 +0000 Subject: [PATCH] fix(ci): format proxy_revocation.rs and accept RUSTSEC-2026-0459 (libsqlite3-sys) Main's rust workflow has failed since #292: proxy_revocation.rs was not rustfmt-clean, and a new advisory for libsqlite3-sys fails cargo audit. The crate is in Cargo.lock only, as sqlx's optional SQLite driver, and is never compiled. sqlx-sqlite 0.9.0 requires libsqlite3-sys below 0.38 and the fix is 0.39, so there is nothing to bump. Recorded in deny.toml, .cargo/audit.toml and ADR-0012. --- .cargo/audit.toml | 1 + crates/limen-e2e/tests/proxy_revocation.rs | 6 +++++- deny.toml | 7 +++++++ docs/adr/0012-dependency-selection.md | 1 + 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.cargo/audit.toml b/.cargo/audit.toml index db761fc2..4034b3a9 100644 --- a/.cargo/audit.toml +++ b/.cargo/audit.toml @@ -2,4 +2,5 @@ [advisories] ignore = [ "RUSTSEC-2023-0071", # rsa Marvin attack: we only verify RS256 with public keys + "RUSTSEC-2026-0459", # libsqlite3-sys: in Cargo.lock only (sqlx's optional SQLite driver), never compiled ] diff --git a/crates/limen-e2e/tests/proxy_revocation.rs b/crates/limen-e2e/tests/proxy_revocation.rs index 03606875..4c17b847 100644 --- a/crates/limen-e2e/tests/proxy_revocation.rs +++ b/crates/limen-e2e/tests/proxy_revocation.rs @@ -192,7 +192,11 @@ async fn a_revoked_proxy_no_longer_serves_the_console() { .status() .as_u16() }; - assert_eq!(status().await, 200, "the sign-in page before the revocation"); + assert_eq!( + status().await, + 200, + "the sign-in page before the revocation" + ); let admin_user = d.login(ADMIN, &["admins"]).await.expect("admin"); let mut admin = AdminClient::new(d.proxy_channel(Some(admin_user))); diff --git a/deny.toml b/deny.toml index d27506e0..db04ec96 100644 --- a/deny.toml +++ b/deny.toml @@ -15,6 +15,13 @@ ignore = [ # Limen only verifies IdP RS256 signatures with public keys and never holds # an RSA private key. No fixed version exists. See ADR-0012. { id = "RUSTSEC-2023-0071", reason = "public-key verification only; no RSA private keys" }, + # libsqlite3-sys (via sqlx-sqlite, an optional driver of sqlx): bundled C + # SQLite CVE. Limen uses sqlx with PostgreSQL only; the SQLite driver is + # never compiled (`cargo tree -i libsqlite3-sys` is empty), but it is in + # Cargo.lock, which cargo-audit scans. sqlx-sqlite 0.9.0 requires + # libsqlite3-sys <0.38 and the fix is 0.39, so no bump is possible until + # sqlx releases. See ADR-0012. + { id = "RUSTSEC-2026-0459", reason = "SQLite driver is never compiled; sqlx-sqlite pins <0.38" }, ] [licenses] diff --git a/docs/adr/0012-dependency-selection.md b/docs/adr/0012-dependency-selection.md index 01f90f8f..d032ff81 100644 --- a/docs/adr/0012-dependency-selection.md +++ b/docs/adr/0012-dependency-selection.md @@ -83,6 +83,7 @@ A dependency is adopted only if all of these hold: | Advisory | Crate (path) | Why it's accepted | |---|---|---| | RUSTSEC-2023-0071 (Marvin attack) | `rsa` (via `openidconnect`) | The attack recovers keys through timing of **private-key** operations. Limen only verifies IdP RS256 ID token signatures with public keys from the IdP's JWKS, and never generates or holds an RSA private key. There is no fixed version. Re-evaluate when `openidconnect` drops `rsa` or a fix ships. | +| RUSTSEC-2026-0459 (C SQLite CVE) | `libsqlite3-sys` (via `sqlx-sqlite`, an optional driver of `sqlx`) | Limen uses `sqlx` with PostgreSQL only. The SQLite driver is never compiled (`cargo tree -i libsqlite3-sys` prints nothing), but `sqlx` lists it as an optional dependency, so it is in `Cargo.lock`, which `cargo audit` scans. `sqlx-sqlite` 0.9.0 requires `libsqlite3-sys` below 0.38 and the fix is 0.39, so no bump is possible until `sqlx` releases one. Re-evaluate on the next `sqlx` release. | ## Terraform registry modules (2026-10-25)