Skip to content

Commit 028fc98

Browse files
author
Ted Young
authored
Merge pull request #32 from carlosalberto/LS-579
Support Python 3
2 parents 83d1c60 + ec08f6c commit 028fc98

14 files changed

Lines changed: 115 additions & 91 deletions

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ test: build
5757
# the command is run within the LightStep development environment (i.e. the
5858
# LIGHTSTEP_HOME environment variable is set).
5959
thrift:
60-
docker run -v "$(PWD)/lightstep:/out" -v "$(LIGHTSTEP_HOME)/go/src/crouton:/data" --rm thrift:0.9.2 \
60+
docker run -v "$(PWD)/lightstep:/out" -v "$(LIGHTSTEP_HOME)/go/src/crouton:/data" --rm thrift:0.10.0 \
6161
thrift -r --gen py -out /out /data/crouton.thrift
62+
python-modernize -w lightstep/crouton/
6263
rm -rf lightstep/crouton/ReportingService-remote

lightstep/crouton/ReportingService.py

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lightstep/crouton/constants.py

Lines changed: 0 additions & 11 deletions
This file was deleted.

lightstep/crouton/ttypes.py

Lines changed: 31 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lightstep/lightstep_binary_propagator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def extract(self, carrier):
3838
raise InvalidCarrierException()
3939
serializedProto = standard_b64decode(carrier)
4040
state = BinaryCarrier()
41-
state.ParseFromString(str(serializedProto))
41+
state.ParseFromString(bytes(serializedProto))
4242
baggage = {}
4343
for k in state.basic_ctx.baggage_items:
4444
baggage[k] = state.basic_ctx.baggage_items[k]
@@ -47,4 +47,4 @@ def extract(self, carrier):
4747
span_id=state.basic_ctx.span_id,
4848
trace_id=state.basic_ctx.trace_id,
4949
baggage=baggage,
50-
sampled=state.basic_ctx.sampled)
50+
sampled=state.basic_ctx.sampled)

0 commit comments

Comments
 (0)