Skip to content

Commit f6dac1a

Browse files
committed
Document that LSPS5 services should double-check the destination
It would be easy to implement an LSPS5 service and forget that the webhook calls are going out based on a URI and headers provided by an untrusted client, so such implementations need to make sure to check if the destination is some internal resource before sending. Reported by Jordan Mecom of Block's Security Team
1 parent 9f73a98 commit f6dac1a

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

lightning-liquidity/src/lsps5/event.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ pub enum LSPS5ServiceEvent {
5656
///
5757
/// This is the [`webhook URL`] provided by the client during registration.
5858
///
59+
/// Obviously as the URL provided here is untrusted you should check whether it would
60+
/// access any internal or private resources and decline to send the request if it is.
61+
///
5962
/// [`webhook URL`]: super::msgs::LSPS5WebhookUrl
6063
url: LSPS5WebhookUrl,
6164
/// Notification method with its parameters.

0 commit comments

Comments
 (0)