Skip to content

install script doesn't correctly remove old ~/.local directory as it removes it from root, not the user running it #105

@gregsadetsky

Description

@gregsadetsky

in https://cli-assets.letsdisco.dev/install.sh

rm -rf ~/.local/share/disco/client

will be run (exactly like in the heroku CLI install script) but because the script (at some point?) is run as sudo, "~" is actually the root home, not the user's home

this leads the user's .local/share/disco to keep existing, and can lead to an older version being run from there

I also saw a case in the wild where ~/local/share/disco/client/bin/disco (approximately that was the path) was actually 0 bytes...!! and channel was empty as well........ bizarre

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions