Skip to content

Commit fb4535e

Browse files
feat(HdrHistogram#115): implement tasks
1 parent f674ef6 commit fb4535e

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

File renamed without changes.
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,51 +13,51 @@ No logic, API surface, or behaviour is altered.
1313

1414
### 1. Apply formatting
1515

16-
- [ ] **Run `dotnet format whitespace HdrHistogram.sln`** to automatically fix all whitespace,
16+
- [x] **Run `dotnet format whitespace HdrHistogram.sln`** to automatically fix all whitespace,
1717
line-ending, charset, and final-newline violations across all four projects.
1818
_Why:_ The brief mandates using the `whitespace` sub-command explicitly to avoid invoking
1919
`style` or `analyzers` fixers that could make non-cosmetic changes.
2020
_Verify:_ Command exits with code 0 and reports files modified.
2121

2222
### 2. Spot-check Bitwise.cs
2323

24-
- [ ] **Inspect the diff for `HdrHistogram/Utilities/Bitwise.cs`** (lines 40–60) using `git diff`
24+
- [x] **Inspect the diff for `HdrHistogram/Utilities/Bitwise.cs`** (lines 40–60) using `git diff`
2525
to confirm the 8 WHITESPACE fixes are indentation-only and contain no logic change.
2626
_Why:_ This is the only file with substantive (non-trivial) formatting changes; the brief
2727
calls it out explicitly as requiring manual verification.
2828
_Verify:_ Diff shows only whitespace/indentation changes; no executable tokens added or removed.
2929

3030
### 3. Verify formatting is fully resolved
3131

32-
- [ ] **Run `dotnet format --verify-no-changes HdrHistogram.sln`** and confirm it exits with
32+
- [x] **Run `dotnet format --verify-no-changes HdrHistogram.sln`** and confirm it exits with
3333
code 0 and reports zero violations.
3434
_Why:_ Acceptance criterion 1 — the formatter must report a clean state after the fix.
3535
_Verify:_ Exit code is 0; output contains no violation lines.
3636

3737
### 4. Confirm build is clean
3838

39-
- [ ] **Run `dotnet build HdrHistogram.sln`** and confirm it succeeds with no errors and no
39+
- [x] **Run `dotnet build HdrHistogram.sln`** and confirm it succeeds with no errors and no
4040
warnings introduced by this change.
4141
_Why:_ Acceptance criterion 2 — reformatting must not break the build.
4242
_Verify:_ Build output ends with `Build succeeded` and warning count is unchanged.
4343

4444
### 5. Confirm all unit tests pass
4545

46-
- [ ] **Run `dotnet test HdrHistogram.sln`** and confirm every test passes.
46+
- [x] **Run `dotnet test HdrHistogram.sln`** and confirm every test passes.
4747
_Why:_ Acceptance criterion 3 — existing tests must continue to pass without modification.
4848
_Verify:_ Test output shows 0 failed, 0 skipped (or same counts as pre-change baseline).
4949

5050
### 6. Commit the formatting change
5151

52-
- [ ] **Stage all modified files** (`git add -u`) and **create a commit** with the exact message:
52+
- [x] **Stage all modified files** (`git add -u`) and **create a commit** with the exact message:
5353
`chore: apply dotnet format to match .editorconfig`
5454
_Why:_ Acceptance criterion 6 — the commit message must match this string exactly so that
5555
tooling (e.g. `git log --grep`) and the blame-ignore-revs entry can reference it reliably.
5656
_Verify:_ `git log -1 --format=%s` outputs the required message verbatim.
5757

5858
### 7. Create `.git-blame-ignore-revs`
5959

60-
- [ ] **Record the SHA** of the formatting commit (`git rev-parse HEAD`) and **create
60+
- [x] **Record the SHA** of the formatting commit (`git rev-parse HEAD`) and **create
6161
`.git-blame-ignore-revs`** at the repository root containing that SHA, prefixed with a
6262
comment line: `# chore: apply dotnet format to match .editorconfig`
6363
_Why:_ Acceptance criterion 5 — the bulk formatting commit must be skippable via
@@ -69,15 +69,15 @@ No logic, API surface, or behaviour is altered.
6969

7070
### 8. Commit `.git-blame-ignore-revs`
7171

72-
- [ ] **Stage and commit `.git-blame-ignore-revs`** with message:
72+
- [x] **Stage and commit `.git-blame-ignore-revs`** with message:
7373
`chore: add .git-blame-ignore-revs for formatting commit`
7474
_Why:_ The brief says to include this file in the same PR; it must be its own commit so it
7575
is not mixed with the formatting diff.
7676
_Verify:_ `git log --oneline -2` shows both the formatting commit and this follow-up commit.
7777

7878
### 9. Open a pull request
7979

80-
- [ ] **Push the branch** and **open a PR against `main`** using `gh pr create`.
80+
- [x] **Push the branch** and **open a PR against `main`** using `gh pr create`.
8181
PR title: `chore: apply dotnet format to match .editorconfig (#115)`
8282
PR body must reference issue #115 and summarise: what was run, violation counts fixed,
8383
and note that `.git-blame-ignore-revs` is included.

0 commit comments

Comments
 (0)