feat(HdrHistogram#119): implement tasks

Author: leecampbell-codeagent

HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFrameworks>net8.0</TargetFrameworks>
+    <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

HdrHistogram.Examples/HdrHistogram.Examples.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFrameworks>net8.0</TargetFrameworks>
+    <TargetFrameworks>net10.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

HdrHistogram.UnitTests/HdrHistogram.UnitTests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>    
-    <TargetFrameworks>net8.0</TargetFrameworks>
+    <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

HdrHistogram/HdrHistogram.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net10.0;net9.0;net8.0;netstandard2.0</TargetFrameworks>
     <Description>HdrHistogram supports low latency recording and analyzing of sampled data value counts across a configurable integer value range with configurable value precision within the range.</Description>
     <Authors>Gil Tene, Lee Campbell</Authors>
     <PackageReleaseNotes>Net 8.0 release</PackageReleaseNotes>
@@ -24,7 +24,15 @@
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net8.0|AnyCPU'">
     <DocumentationFile>bin\Release\net8.0\HdrHistogram.xml</DocumentationFile>
   </PropertyGroup>
-  
+
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net9.0|AnyCPU'">
+    <DocumentationFile>bin\Release\net9.0\HdrHistogram.xml</DocumentationFile>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net10.0|AnyCPU'">
+    <DocumentationFile>bin\Release\net10.0\HdrHistogram.xml</DocumentationFile>
+  </PropertyGroup>
+
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'">
     <DocumentationFile>bin\Release\netstandard2.0\HdrHistogram.xml</DocumentationFile>
     <DefineConstants>RELEASE;NETSTANDARD2_0</DefineConstants>

autonomous/Dockerfile

@@ -2,8 +2,11 @@
 # HdrHistogram.NET Agent Container
 # .NET SDK + Claude Code + gh CLI + firewall
 # =============================================================================
-FROM mcr.microsoft.com/dotnet/sdk:9.0-bookworm-slim
+FROM mcr.microsoft.com/dotnet/sdk:10.0-bookworm-slim
 RUN dotnet_version=8.0 \
+    && curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin \
+       --runtime dotnet --channel $dotnet_version --install-dir /usr/share/dotnet \
+    && dotnet_version=9.0 \
     && curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin \
        --runtime dotnet --channel $dotnet_version --install-dir /usr/share/dotnet
 

plan/ready/brief.md plan/done/brief.mdplan/ready/brief.md renamed to plan/done/brief.md

@@ -8,11 +8,11 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `HdrHistogram/HdrHistogram.csproj`
 
-- [ ] **1.1** Change `<TargetFrameworks>` on line 4 from `net8.0;netstandard2.0` to
+- [x] **1.1** Change `<TargetFrameworks>` on line 4 from `net8.0;netstandard2.0` to
   `net10.0;net9.0;net8.0;netstandard2.0`.
   Verify: the element reads exactly `<TargetFrameworks>net10.0;net9.0;net8.0;netstandard2.0</TargetFrameworks>`.
 
-- [ ] **1.2** Add two `<PropertyGroup>` conditions for the Release `DocumentationFile`,
+- [x] **1.2** Add two `<PropertyGroup>` conditions for the Release `DocumentationFile`,
   mirroring the existing block at lines 24–26.
   Add one block for `net9.0` (`bin\Release\net9.0\HdrHistogram.xml`) and one for
   `net10.0` (`bin\Release\net10.0\HdrHistogram.xml`), immediately after the
@@ -28,7 +28,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `HdrHistogram.UnitTests/HdrHistogram.UnitTests.csproj`
 
-- [ ] **2.1** Change `<TargetFrameworks>` on line 4 from `net8.0` to
+- [x] **2.1** Change `<TargetFrameworks>` on line 4 from `net8.0` to
   `net10.0;net9.0;net8.0`.
   Verify: the element reads exactly `<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>`.
 
@@ -41,7 +41,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `HdrHistogram.Examples/HdrHistogram.Examples.csproj`
 
-- [ ] **3.1** Change `<TargetFrameworks>` on line 5 from `net8.0` to `net10.0`.
+- [x] **3.1** Change `<TargetFrameworks>` on line 5 from `net8.0` to `net10.0`.
   Verify: the element reads exactly `<TargetFrameworks>net10.0</TargetFrameworks>`.
 
 > Covers acceptance criterion: **AC-3**.
@@ -52,18 +52,18 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj`
 
-- [ ] **4.1** Change `<TargetFrameworks>` on line 5 from `net8.0` to
+- [x] **4.1** Change `<TargetFrameworks>` on line 5 from `net8.0` to
   `net10.0;net9.0;net8.0`.
   Verify: the element reads exactly `<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>`.
 
-- [ ] **4.2** Attempt a Release build of the benchmarking project:
+- [x] **4.2** Attempt a Release build of the benchmarking project:
   ```bash
   dotnet build HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj -c Release
   ```
   If the build succeeds, this task is done — BenchmarkDotNet 0.13.12 is compatible.
   If the build fails due to BenchmarkDotNet incompatibility with net10.0, proceed to task 4.3.
 
-- [ ] **4.3** *(Conditional — only if task 4.2 fails)* Upgrade both
+- [x] **4.3** *(Conditional — only if task 4.2 fails)* Upgrade both
   `BenchmarkDotNet` and `BenchmarkDotNet.Diagnostics.Windows` to the latest
   stable version.
   Verify: `dotnet build HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj -c Release`
@@ -78,7 +78,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `.github/workflows/ci.yml`
 
-- [ ] **5.1** Replace the `setup-dotnet` step (lines 15–19) with a single step using
+- [x] **5.1** Replace the `setup-dotnet` step (lines 15–19) with a single step using
   a multi-line `dotnet-version` scalar:
   ```yaml
   - uses: actions/setup-dotnet@v4
@@ -102,12 +102,12 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `.devcontainer/Dockerfile`
 
-- [ ] **6.1** Change the `FROM` line (line 5) from
+- [x] **6.1** Change the `FROM` line (line 5) from
   `mcr.microsoft.com/dotnet/sdk:9.0-bookworm-slim` to
   `mcr.microsoft.com/dotnet/sdk:10.0-bookworm-slim`.
   Verify: the first `FROM` line references `sdk:10.0-bookworm-slim`.
 
-- [ ] **6.2** Replace the single 8.0 runtime install (lines 6–8) with explicit
+- [x] **6.2** Replace the single 8.0 runtime install (lines 6–8) with explicit
   installs of both the 8.0 and 9.0 runtimes via `dotnet-install.sh`, keeping both
   in the same `RUN` layer to avoid creating extra image layers:
   ```dockerfile
@@ -129,7 +129,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `spec/tech-standards/build-system.md`, approx. lines 24–26
 
-- [ ] **7.1** In the "Main Library (HdrHistogram.csproj)" section, update the XML
+- [x] **7.1** In the "Main Library (HdrHistogram.csproj)" section, update the XML
   code block from:
   ```xml
   <TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
@@ -148,7 +148,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `spec/tech-standards/build-system.md`, approx. lines 35–37
 
-- [ ] **8.1** In the "Test Project" section, update the XML code block from:
+- [x] **8.1** In the "Test Project" section, update the XML code block from:
   ```xml
   <TargetFramework>net8.0</TargetFramework>
   ```
@@ -168,7 +168,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `spec/tech-standards/build-system.md`, approx. lines 42–45
 
-- [ ] **9.1** In the "Benchmarking Project" section, update the description text
+- [x] **9.1** In the "Benchmarking Project" section, update the description text
   "Targets the current LTS runtime only (developer tool, not a shipped library):" to
   reflect multi-targeting, and update the XML code block from:
   ```xml
@@ -188,7 +188,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `spec/tech-standards/build-system.md`, approx. lines 226–228
 
-- [ ] **10.1** In the "Benchmark Configuration" section, replace the single target entry:
+- [x] **10.1** In the "Benchmark Configuration" section, replace the single target entry:
   ```
   - `net8.0` (current LTS runtime)
   ```
@@ -200,7 +200,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
   ```
   Verify: the bullet list covers all three TFMs.
 
-- [ ] **10.2** *(Conditional — only if task 4.3 was executed)* Update the BenchmarkDotNet
+- [x] **10.2** *(Conditional — only if task 4.3 was executed)* Update the BenchmarkDotNet
   version numbers in the "Benchmarking Project" dependencies code block
   (approx. lines 66–67) to match the upgraded version.
   Verify: the version string in the spec matches the version in
@@ -214,7 +214,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 
 **File:** `spec/tech-standards/build-system.md`, approx. line 254
 
-- [ ] **11.1** In the "Prerequisites" section, change:
+- [x] **11.1** In the "Prerequisites" section, change:
   ```
   - .NET 8.0 SDK (or later)
   ```
@@ -233,23 +233,23 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
 These tasks confirm all acceptance criteria related to running the toolchain.
 They must be performed **after** all implementation tasks above are complete.
 
-- [ ] **12.1** Run a Release build of the main library and confirm it succeeds for
+- [x] **12.1** Run a Release build of the main library and confirm it succeeds for
   all four target frameworks:
   ```bash
   dotnet build HdrHistogram/HdrHistogram.csproj -c Release
   ```
   Verify: build output shows `net10.0`, `net9.0`, `net8.0`, and `netstandard2.0`
   all built without errors.
 
-- [ ] **12.2** Run the full test suite and confirm all tests pass on all three
+- [x] **12.2** Run the full test suite and confirm all tests pass on all three
   modern runtimes:
   ```bash
   dotnet test HdrHistogram.UnitTests/HdrHistogram.UnitTests.csproj -c Release
   ```
   Verify: test results show three separate `net10.0`, `net9.0`, and `net8.0` runs,
   all green with zero failures.
 
-- [ ] **12.3** Pack the library and confirm all four TFM folders are present in
+- [x] **12.3** Pack the library and confirm all four TFM folders are present in
   the produced `.nupkg`:
   ```bash
   dotnet pack HdrHistogram/HdrHistogram.csproj -c Release --no-build
@@ -266,6 +266,27 @@ They must be performed **after** all implementation tasks above are complete.
 
 ---
 
+---
+
+## 13 — Code review fixes
+
+Issues found during post-implementation review and resolved.
+
+- [x] **13.1** BenchmarkDotNet version regression: the branch base had `0.13.12` but
+  `upstream/main` already upgraded to `0.15.8`.
+  Updated `HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj` to `0.15.8`.
+  Verified: `dotnet build -c Release -p:TargetFrameworks=net9.0` succeeds.
+
+- [x] **13.2** `spec/tech-standards/build-system.md` BenchmarkDotNet version block
+  also reflected the old `0.13.12`.
+  Updated both package references in the spec to `0.15.8` to match the csproj.
+
+- [x] **13.3** `spec/tech-standards/build-system.md` TFM description table in the
+  "Main Library" section was missing rows for `net9.0` and `net10.0`.
+  Added `net10.0` (current LTS target), `net9.0` (STS target), and `net8.0` (LTS target) rows.
+
+---
+
 ## Acceptance Criterion Cross-Reference
 
 | Criterion | Tasks |

plan/ready/task.md plan/done/task.mdplan/ready/task.md renamed to plan/done/task.md

@@ -22,26 +22,28 @@ HdrHistogram.sln
 ### Main Library (HdrHistogram.csproj)
 
 ```xml
-<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
+<TargetFrameworks>net10.0;net9.0;net8.0;netstandard2.0</TargetFrameworks>
 ```
 
 | Target | Description |
 |--------|-------------|
-| `net8.0` | Modern .NET (primary target) |
+| `net10.0` | Modern .NET (current LTS target) |
+| `net9.0` | Modern .NET (STS target) |
+| `net8.0` | Modern .NET (LTS target) |
 | `netstandard2.0` | Broad compatibility (.NET Framework 4.6.1+, .NET Core 2.0+) |
 
 ### Test Project
 
 ```xml
-<TargetFramework>net8.0</TargetFramework>
+<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
 ```
 
 ### Benchmarking Project
 
-Targets the current LTS runtime only (developer tool, not a shipped library):
+Targets all supported modern runtimes (developer tool, not a shipped library):
 
 ```xml
-<TargetFrameworks>net8.0</TargetFrameworks>
+<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
 ```
 
 ## Dependencies
@@ -224,7 +226,9 @@ dotnet run -c Release -- -f *Recording*
 ### Benchmark Configuration
 
 BenchmarkDotNet is used with these targets:
-- `net8.0` (current LTS runtime)
+- `net10.0` (current LTS runtime)
+- `net9.0` (STS runtime)
+- `net8.0` (LTS runtime)
 - Windows diagnostics support
 - Memory allocation tracking
 
@@ -251,7 +255,7 @@ HdrHistogram/bin/{Configuration}/{TargetFramework}/
 
 ### Prerequisites
 
-- .NET 8.0 SDK (or later)
+- .NET 10.0 SDK (or later)
 - Visual Studio 2022 (optional, for IDE development)
 - Git