fix: Write the log prefix once on the reloader's unexpected error line

Author: kinyoklion

lib/ldclient-rb/impl/file_data/reloader.rb

@@ -2,7 +2,6 @@
 
 require "ldclient-rb/impl/file_data/document"
 require "ldclient-rb/impl/file_data/merge"
-require "ldclient-rb/impl/util"
 
 require "digest"
 
@@ -167,7 +166,8 @@ def stop
             end
           end
         rescue => e
-          Util.log_exception(@logger, "#{@log_prefix} Unexpected error in file data reloader", e)
+          @logger.error { "#{@log_prefix} Unexpected error in file data reloader: #{e.inspect}" }
+          @logger.debug { "#{@log_prefix} Exception trace: #{e.backtrace}" }
         end
 
         #

spec/impl/file_data/reloader_spec.rb

@@ -435,6 +435,19 @@ def with_reloader(paths, logger: $null_log, reject: 0, **options)
             expect(logger.output).to include("Reloading flag data after detecting a change")
           end
         end
+
+        it "writes the configured prefix once on the log line for an unexpected error" do
+          a = write("a.json", values_doc({ flag1: "a" }))
+          logger = CapturingLogger.new
+          allow(FileData).to receive(:read_file).and_raise(RuntimeError, "unexpected")
+
+          with_reloader([a], logger: logger, debounce_delay: 0, log_prefix: "[LDClient] Prefix:") do |reloader, _recorder|
+            reloader.trigger
+
+            expect(wait_for { logger.output.include?("Unexpected error") }).to be true
+            expect(logger.output).to match(/ERROR -- : \[LDClient\] Prefix: Unexpected error in file data reloader/)
+          end
+        end
       end
     end
   end