Fix async files operations#42
Merged
Merged
Conversation
The bug: SandboxFilesystem.upload_file calls self.write_file() and download_file calls self.read_file(). When these sync methods run in the executor thread via async_wrapper, self is the AsyncSandboxFilesystem instance, so self.write_file() dispatches to the async override and returns an unawaited coroutine. The fix: call SandboxFilesystem.write_file(self, ...) and SandboxFilesystem.read_file(self, ...) explicitly so the sync methods always invoke the sync implementations, regardless of which subclass self is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug: SandboxFilesystem.upload_file calls self.write_file() and download_file calls
self.read_file(). When these sync methods run in the executor thread via async_wrapper,
self is the AsyncSandboxFilesystem instance, so self.write_file() dispatches to the async
override and returns an unawaited coroutine.
The fix: call SandboxFilesystem.write_file(self, ...) and SandboxFilesystem.read_file(self,
...) explicitly so the sync methods always invoke the sync implementations, regardless of
which subclass self is.