Merge pull request #137 from keyxmakerx/claude/phase-sprint-planning-MEZXp

feat: integrate NPC plugin into the addon framework for per-campaign …

Author: keyxmakerx

db/migrations/000007_add_npcs_addon.down.sql

@@ -0,0 +1 @@
+DELETE FROM addons WHERE slug = 'npcs';

db/migrations/000007_add_npcs_addon.up.sql

@@ -0,0 +1,4 @@
+-- Register the NPC Gallery as a toggleable addon so campaign owners can
+-- enable/disable it from the Plugin Hub, just like calendar, maps, etc.
+INSERT INTO addons (slug, name, description, version, category, status, icon, author)
+VALUES ('npcs', 'NPC Gallery', 'Browse and reveal character entities as NPCs for your players.', '1.0.0', 'plugin', 'active', 'fa-users', 'Chronicle');

internal/app/routes.go

@@ -1016,7 +1016,7 @@ func (a *App) RegisterRoutes() {
 	npcSvc := npcs.NewNPCService(npcRepo, &npcEntityTypeFinderAdapter{svc: entityService})
 	npcHandler := npcs.NewHandler(npcSvc)
 	npcHandler.SetVisibilityToggler(&npcVisibilityTogglerAdapter{svc: entityService})
-	npcs.RegisterRoutes(e, npcHandler, campaignService, authService)
+	npcs.RegisterRoutes(e, npcHandler, campaignService, authService, addonService)
 
 	// Notes widget: personal floating note-taking panel (Google Keep-style).
 	noteRepo := notes.NewNoteRepository(a.DB)
@@ -1087,7 +1087,7 @@ func (a *App) RegisterRoutes() {
 	// NPC gallery block — embeds a compact NPC grid on entity pages/dashboards.
 	blockRegistry.Register(entities.BlockMeta{
 		Type: "npc_gallery", Label: "NPC Gallery", Icon: "fa-users",
-		Description: "Grid of revealed NPCs",
+		Description: "Grid of revealed NPCs", Addon: "npcs",
 	}, func(bctx entities.BlockRenderContext) templ.Component {
 		limit := entities.BlockConfigLimit(bctx.Block.Config, "limit", 8)
 		cards, err := npcHandler.GalleryBlock(context.Background(), bctx.CC.Campaign.ID, int(bctx.CC.MemberRole), "", limit)

internal/plugins/addons/service.go

@@ -129,6 +129,7 @@ var installedAddons = map[string]bool{
 	"sessions":       true,
 	"timeline":       true,
 	"media-gallery":  true,
+	"npcs":           true,
 	"dnd5e":          true,
 	"pathfinder2e":   true,
 	"drawsteel":      true,

internal/plugins/npcs/.ai.md

@@ -6,6 +6,12 @@ The NPC gallery provides a dedicated hub for revealed (non-private) character en
 in a campaign. It gives players a visual directory of NPCs they've encountered, and
 DMs a quick way to reveal/hide characters from player view.
 
+## Addon Gating
+
+Registered as the `npcs` addon (category: `plugin`, status: `active`). Campaign owners
+enable/disable it from the Plugin Hub. All routes use `addons.RequireAddon(addonSvc, "npcs")`
+middleware. Sidebar link and `npc_gallery` layout block are gated behind `IsAddonEnabled(ctx, "npcs")`.
+
 ## Architecture
 
 This is a **view plugin** — it has no database tables. All data comes from the existing
@@ -69,7 +75,7 @@ type TagLister interface {
 
 Type: `npc_gallery`
 Config: `{"limit": 8}` (default 8 cards)
-Always available (no addon requirement).
+Gated behind the `npcs` addon — hidden when addon is disabled for the campaign.
 
 ## Foundry VTT Sync
 

internal/plugins/npcs/routes.go

@@ -5,25 +5,29 @@ package npcs
 import (
 	"github.com/labstack/echo/v4"
 
+	"github.com/keyxmakerx/chronicle/internal/plugins/addons"
 	"github.com/keyxmakerx/chronicle/internal/plugins/auth"
 	"github.com/keyxmakerx/chronicle/internal/plugins/campaigns"
 )
 
 // RegisterRoutes sets up NPC gallery routes on the Echo instance.
 // Public-capable routes use AllowPublicCampaignAccess so public campaigns
-// show NPCs to unauthenticated visitors.
-func RegisterRoutes(e *echo.Echo, h *Handler, campaignSvc campaigns.CampaignService, authSvc auth.AuthService) {
+// show NPCs to unauthenticated visitors. All routes are gated behind the
+// "npcs" addon — campaign owners can enable/disable via the Plugin Hub.
+func RegisterRoutes(e *echo.Echo, h *Handler, campaignSvc campaigns.CampaignService, authSvc auth.AuthService, addonSvc addons.AddonService) {
 	// Authenticated routes: reveal toggle (Scribe+).
 	cg := e.Group("/campaigns/:id",
 		auth.RequireAuth(authSvc),
 		campaigns.RequireCampaignAccess(campaignSvc),
+		addons.RequireAddon(addonSvc, "npcs"),
 	)
 	cg.POST("/npcs/:eid/reveal", h.ToggleReveal, campaigns.RequireRole(campaigns.RoleScribe))
 
 	// Public-capable routes: gallery view (Player+).
 	pub := e.Group("/campaigns/:id",
 		auth.OptionalAuth(authSvc),
 		campaigns.AllowPublicCampaignAccess(campaignSvc),
+		addons.RequireAddon(addonSvc, "npcs"),
 	)
 	pub.GET("/npcs", h.Index, campaigns.RequireRole(campaigns.RolePlayer))
 	pub.GET("/npcs/count", h.CountAPI, campaigns.RequireRole(campaigns.RolePlayer))

internal/templates/layouts/app.templ

@@ -246,6 +246,7 @@ templ Sidebar() {
 							</span>
 							<span class="flex-1">All Pages</span>
 						</a>
+						if IsAddonEnabled(ctx, "npcs") {
 						<a
 							href={ templ.SafeURL(fmt.Sprintf("/campaigns/%s/npcs", GetCampaignID(ctx))) }
 							class={ sidebarNavLink,
@@ -257,6 +258,7 @@ templ Sidebar() {
 							</span>
 							<span class="flex-1">NPCs</span>
 						</a>
+						}
 						<!-- Custom sidebar sections and links -->
 						if len(GetCustomSections(ctx)) > 0 || len(GetCustomLinks(ctx)) > 0 {
 							for _, link := range GetCustomLinks(ctx) {