Skip to content

Commit 2a23766

Browse files
Jeny Sadadianuclearcat
authored andcommitted
api.main: fix delete user group endpoint
Fix `DELETE /group/{group-id}` endpoint's response model by using `pagination_ctx`. Also return `HTTP 204` status code for successful delete operation as per the convention. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
1 parent b14cf1f commit 2a23766

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

api/main.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from fastapi.encoders import jsonable_encoder
2828
from fastapi.responses import JSONResponse, PlainTextResponse, FileResponse
2929
from fastapi.security import OAuth2PasswordRequestForm
30-
from fastapi_pagination import add_pagination
30+
from fastapi_pagination import add_pagination, pagination_ctx
3131
from fastapi_versioning import VersionedFastAPI
3232
from bson import ObjectId, errors
3333
from pymongo.errors import DuplicateKeyError
@@ -417,7 +417,9 @@ async def get_group(group_id: str):
417417
return await db.find_by_id(UserGroup, group_id)
418418

419419

420-
@app.delete('/group/{group_id}', response_model=PageModel)
420+
@app.delete('/group/{group_id}',
421+
dependencies=[Depends(pagination_ctx(PageModel))],
422+
status_code=status.HTTP_204_NO_CONTENT)
421423
async def delete_group(group_id: str,
422424
current_user: User = Depends(get_current_superuser)):
423425
"""Delete user group matching the provided group id"""

0 commit comments

Comments
 (0)