Skip to content

Commit a620e5c

Browse files
committed
add tests and godoc
1 parent e84f1b1 commit a620e5c

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

error_113_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,15 @@ func TestErrorUnwrap(t *testing.T) {
3434
unwrapped := errors.Unwrap(err)
3535
require.NotNil(t, unwrapped)
3636
require.True(t, IsOfType(unwrapped, testType))
37+
require.True(t, Cast(unwrapped).Type() == testType)
3738
})
3839

3940
t.Run("DecorateForeign", func(t *testing.T) {
4041
err := Decorate(io.EOF, "")
4142
unwrapped := errors.Unwrap(err)
4243
require.NotNil(t, unwrapped)
4344
require.True(t, errors.Is(unwrapped, io.EOF))
45+
require.True(t, unwrapped == io.EOF)
4446
})
4547

4648
t.Run("Nested", func(t *testing.T) {
@@ -79,26 +81,25 @@ func TestErrorIs(t *testing.T) {
7981
})
8082

8183
t.Run("Wrap", func(t *testing.T) {
82-
err := testTypeBar1.Wrap(testType.NewWithNoMessage(),"")
84+
err := testTypeBar1.Wrap(testType.NewWithNoMessage(), "")
8385
require.False(t, errors.Is(err, testType.NewWithNoMessage()))
8486
require.True(t, errors.Is(err, testTypeBar1.NewWithNoMessage()))
8587
})
8688

8789
t.Run("Supertype", func(t *testing.T) {
88-
err := testSubtype0.Wrap(testTypeBar1.NewWithNoMessage(),"")
90+
err := testSubtype0.Wrap(testTypeBar1.NewWithNoMessage(), "")
8991
require.True(t, errors.Is(err, testType.NewWithNoMessage()))
9092
require.True(t, errors.Is(err, testSubtype0.NewWithNoMessage()))
9193
require.False(t, errors.Is(err, testTypeBar1.NewWithNoMessage()))
9294
})
9395

9496
t.Run("Decorate", func(t *testing.T) {
95-
err := Decorate(testType.NewWithNoMessage(),"")
97+
err := Decorate(testType.NewWithNoMessage(), "")
9698
require.True(t, errors.Is(err, testType.NewWithNoMessage()))
9799
})
98100

99101
t.Run("DecorateForeign", func(t *testing.T) {
100-
err := Decorate(io.EOF,"")
102+
err := Decorate(io.EOF, "")
101103
require.True(t, errors.Is(err, io.EOF))
102104
})
103105
}
104-

type.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (t *Type) NewWithNoMessage() *Error {
5656
// The original error will not pass its dynamic properties, and those are accessible only via direct walk over Cause() chain.
5757
// Without args, leaves the original message intact, so a message may be generated or provided externally.
5858
// With args, a formatting is performed, and it is therefore expected a format string to be constant.
59-
// NB: Wrap is NOT the reverse of Error.Unwrap method; name may be changed in future releases to avoid confusion.
59+
// NB: Wrap is NOT the reverse of errors.Unwrap() or Error.Unwrap() method; name may be changed in future releases to avoid confusion.
6060
func (t *Type) Wrap(err error, message string, args ...interface{}) *Error {
6161
return NewErrorBuilder(t).
6262
WithConditionallyFormattedMessage(message, args...).

0 commit comments

Comments
 (0)