PRO-10170 fix: getGlobalErrorHandler (don't use test context)

Author: uid11

autotests/entities/worker.ts

@@ -4,11 +4,10 @@ import {log} from 'e2ed/utils';
 import type {UserWorker} from 'autotests/types';
 import type {ClientFunction} from 'e2ed/types';
 
-const clientGetUsers = createClientFunction(
-  (delay: number) =>
-    fetch(`https://reqres.in/api/users?delay=${delay}`, {method: 'GET'}).then((res) => res.json()),
-  {name: 'getUsers', timeout: 6_000},
-);
+type GetUsersOptions = Readonly<{delay?: number; retries?: number}> | undefined;
+
+let clientGetUsers: ClientFunction<[number], unknown> | undefined;
+let clientGetUsersRetries: number | undefined;
 
 /**
  * Adds user-worker.
@@ -26,8 +25,20 @@ export const addUser: ClientFunction<[UserWorker, number?], Promise<object>> = c
 /**
  * Get list of user-workers.
  */
-export const getUsers = (delay: number = 0): Promise<unknown> => {
+export const getUsers = ({delay = 0, retries = 0}: GetUsersOptions = {}): Promise<unknown> => {
   log(`Send API request with delay = ${delay}s`);
 
+  if (clientGetUsers === undefined || clientGetUsersRetries !== retries) {
+    clientGetUsersRetries = retries;
+
+    clientGetUsers = createClientFunction(
+      (clientDelay: number) =>
+        fetch(`https://reqres.in/api/users?delay=${clientDelay}`, {method: 'GET'}).then(
+          (res) => res.json() as unknown,
+        ),
+      {name: 'getUsers', retries, timeout: 6_000},
+    );
+  }
+
   return clientGetUsers(delay);
 };

autotests/packs/allTests.ts

@@ -52,7 +52,7 @@ export const pack: Pack = {
   deviceScaleFactor: 1,
   doAfterPack,
   doBeforePack,
-  enableCsp: true,
+  enableCsp: false,
   enableHeadlessMode: true,
   enableMobileDeviceMode: false,
   enableTouchEventEmulation: false,
@@ -80,7 +80,7 @@ export const pack: Pack = {
   skipTests,
   takeFullPageScreenshotOnError: false,
   takeViewportScreenshotOnError: true,
-  testFileGlobs: ['**/autotests/tests/**/*.ts'],
+  testFileGlobs: ['**/autotests/tests/**/switchingPages.ts'],
   testIdleTimeout: 8_000,
   testTimeout: 15_000,
   userAgent,

autotests/tests/switchingPages.skip.ts autotests/tests/switchingPages.tsautotests/tests/switchingPages.skip.ts renamed to autotests/tests/switchingPages.ts

@@ -18,7 +18,7 @@ test('support switching of pages and tabs', {meta: {testId: '21'}}, async () =>
     if (numberOfSentRequests < maxNumberOfRequests) {
       numberOfSentRequests += 1;
 
-      void getUsers();
+      void getUsers({retries: 1});
     }
   }, 1_000);
 

autotests/tests/waitForAllRequestsComplete.ts

@@ -33,7 +33,7 @@ test(
 
     let promise = waitForAllRequestsComplete(() => true, {timeout: 1000});
 
-    void getUsers(2);
+    void getUsers({delay: 2});
 
     await assertFunctionThrows(
       () => promise,
@@ -46,7 +46,7 @@ test(
       throw new E2edError('waitForAllRequestsComplete did not wait for timeout', {waitedInMs});
     }
 
-    void getUsers(2);
+    void getUsers({delay: 2});
 
     startRequestInMs = Date.now();
 
@@ -66,9 +66,9 @@ test(
 
     promise = waitForAllRequestsComplete(() => true);
 
-    await getUsers(1);
+    await getUsers({delay: 1});
     await waitForTimeout(400);
-    await getUsers(1);
+    await getUsers({delay: 1});
 
     startRequestInMs = Date.now();
 
@@ -85,7 +85,7 @@ test(
 
     promise = waitForAllRequestsComplete(() => true, {maxIntervalBetweenRequestsInMs: 300});
 
-    await getUsers(1);
+    await getUsers({delay: 1});
 
     startRequestInMs = Date.now();
 

src/createClientFunction.ts

@@ -9,14 +9,14 @@ import {getPlaywrightPage} from './useContext';
 
 import type {ClientFunction} from './types/internal';
 
-type Options = Readonly<{name?: string; timeout?: number}>;
+type Options = Readonly<{name?: string; retries?: number; timeout?: number}>;
 
 /**
  * Creates a client function.
  */
 export const createClientFunction = <Args extends readonly unknown[], Result>(
   originalFn: (...args: Args) => Result,
-  {name: nameFromOptions, timeout}: Options = {},
+  {name: nameFromOptions, retries = 0, timeout}: Options = {},
 ): ClientFunction<Args, Result> => {
   setCustomInspectOnFunction(originalFn);
 
@@ -48,6 +48,18 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
           return page.evaluate(func, args);
         }
 
+        if (retries > 0) {
+          let retryIndex = 1;
+
+          while (retryIndex <= retries) {
+            retryIndex += 1;
+
+            try {
+              return page.evaluate(func, args);
+            } catch {}
+          }
+        }
+
         throw evaluateError;
       }),
       clientFunctionTimeout,

src/test.ts

@@ -7,8 +7,6 @@ import type {TestFunction} from './types/internal';
 
 import {test as playwrightTest} from '@playwright/test';
 
-process.removeAllListeners('unhandledRejection');
-
 process.on('uncaughtException', getGlobalErrorHandler('TestUncaughtException'));
 process.on('unhandledRejection', getGlobalErrorHandler('TestUnhandledRejection'));
 

src/utils/getGlobalErrorHandler.ts

@@ -1,9 +1,5 @@
-import {getMeta} from '../context/meta';
-import {getRunId} from '../context/runId';
-
 import {E2edError} from './error';
 import {writeGlobalError} from './fs';
-import {generalLog} from './generalLog';
 
 import type {GlobalErrorType} from '../types/internal';
 
@@ -14,20 +10,7 @@ import type {GlobalErrorType} from '../types/internal';
 export const getGlobalErrorHandler =
   (type: GlobalErrorType) =>
   (cause: unknown): void => {
-    const message = `Caught ${type}`;
-
-    if (type.startsWith('Test')) {
-      const meta = getMeta();
-      const runId = getRunId();
-
-      generalLog(message, {cause, meta, runId});
-
-      return;
-    }
-
-    generalLog(message, {cause});
-
-    const error = new E2edError(message, {cause});
+    const error = new E2edError(`Caught ${type}`, {cause});
 
     void writeGlobalError(error.toString());
   };