Skip to content

Commit 47d423d

Browse files
committed
Issue 20: add QML sign/verify message flow and tests
1 parent dd6f100 commit 47d423d

11 files changed

Lines changed: 1210 additions & 2 deletions

doc/test-automation-selectors.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ It supports the parity backlog Definition of Done (`DefinitionOfDone.md`) requir
2424
- Receive flow: `receiveAmountInput`, `receiveLabelInput`, `receiveContactSelectButton`, `receiveContactsPopup`, `receiveContactsSearchInput`, `receiveContactRow`, `receiveContactSelectFirstActionButton`, `receiveContactUseButton`, `receiveCreateAddressButton`, `receiveCopySelectedUriButton`, `receiveQrImage`
2525
- Send flow: `sendAddressInput`, `sendOpenContactsButton`, `sendContactsPopup`, `sendContactsSearchInput`, `sendContactLabelInput`, `sendContactAddressInput`, `sendContactSaveButton`, `sendContactDeleteButton`, `sendContactUseButton`, `sendContinueButton`, `sendPaymentRequestStatusText`, `sendPaymentRequestMessageText`, `sendOptionsPastePaymentRequestButton`, `sendOptionsOpenPaymentRequestButton`, `sendOptionsImportPaymentRequestFileButton`, `sendOptionsPsbtOperationsButton`, `sendUriImportPopup`, `sendUriImportInput`, `sendUriImportApplyButton`, `sendUriImportCancelButton`, `sendImportPaymentRequestFileDialog`, `sendPaymentRequestDropArea`, `sendPaymentRequestDropHint`, `sendDropUriInput`, `sendApplyDropUriButton`, `sendImportPaymentRequestFilePathInput`, `sendApplyPaymentRequestFilePathButton`, `sendReviewCopyPsbtButton`, `sendReviewSavePsbtButton`, `sendReviewSavePsbtFileDialog`, `sendReviewPsbtStatusText`, `multipleSendReviewCopyPsbtButton`, `multipleSendReviewSavePsbtButton`, `multipleSendReviewSavePsbtFileDialog`, `multipleSendReviewPsbtStatusText`, `sendResultPopup`
2626
- PSBT operations flow: `psbtOperationsPage`, `psbtOperationsBackButton`, `psbtImportClipboardButton`, `psbtImportFileButton`, `psbtImportFileDialog`, `psbtWorkflowStatusText`, `psbtInputSummaryText`, `psbtSignButton`, `psbtFinalizeButton`, `psbtBroadcastButton`, `psbtCopyButton`, `psbtSaveButton`, `psbtSaveFileDialog`, `psbtStatusText`, `psbtBroadcastTxidText`
27+
- Sign/verify message flow: `walletSelectSignMessageButton`, `walletSelectVerifyMessageButton`, `signVerifyMessagePage`, `signVerifyMessageBackButton`, `signVerifySignTab`, `signVerifyVerifyTab`, `signVerifySignAddressInput`, `signVerifySignAddressBookButton`, `signVerifySignPasteAddressButton`, `signVerifySignMessageInput`, `signVerifySignPassphraseInput`, `signVerifySignSignatureOutput`, `signVerifySignCopySignatureButton`, `signVerifySignButton`, `signVerifySignClearButton`, `signVerifySignStatusText`, `signVerifyVerifyAddressInput`, `signVerifyVerifyAddressBookButton`, `signVerifyVerifyMessageInput`, `signVerifyVerifySignatureInput`, `signVerifyVerifyButton`, `signVerifyVerifyClearButton`, `signVerifyVerifyStatusText`, `signVerifyAddressBookPopup`, `signVerifyAddressBookSearchInput`, `signVerifyAddressBookList`, `signVerifyAddressBookSelectFirstActionButton`, `signVerifyAddressBookUseButton`
2728
- Wallet tabs/pages: `walletSendPage`, `walletRequestPaymentPage`, `activityListView`, `activityOpenFirstRowActionButton`, `activityOpenRowAddressInput`, `activityOpenRowByAddressActionButton`, `activityDetailsPage`, `activityDetailsBackButton`
2829
- Activity RBF actions: `activityDetailsBumpButton`, `activityDetailsBumpPopup`, `activityDetailsBumpPreviewButton`, `activityDetailsBumpConfirmPopup`, `activityDetailsBumpConfirmButton`, `activityDetailsBumpDisabledReasonText`, `activityDetailsCancelButton`, `activityDetailsCancelPopup`, `activityDetailsCancelConfirmButton`, `activityDetailsRbfStatusText`, `activityDetailsReplacementTxidText`
2930
- Onboarding storage flow: `onboardingStorageAmountDetailedSettingsButton`, `storageSettingsPruneTargetInput`, `storageLocationDefaultOption`

qml/bitcoin_qml.qrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@
107107
<file>pages/wallet/Send.qml</file>
108108
<file>pages/wallet/SendResult.qml</file>
109109
<file>pages/wallet/SendReview.qml</file>
110+
<file>pages/wallet/SignVerifyMessage.qml</file>
110111
<file>pages/wallet/WalletBadge.qml</file>
111112
<file>pages/wallet/WalletSelect.qml</file>
112113
</qresource>

qml/pages/main.qml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,9 @@ ApplicationWindow {
156156
main.push(sendReviewPage)
157157
}
158158
}
159+
onOpenSignVerifyMessage: (initialTab) => {
160+
main.push(signVerifyMessagePage, { "initialTab": initialTab })
161+
}
159162
}
160163
}
161164

@@ -201,6 +204,11 @@ ApplicationWindow {
201204
closePolicy: Popup.CloseOnPressOutside
202205
}
203206

207+
Component {
208+
id: signVerifyMessagePage
209+
SignVerifyMessage {}
210+
}
211+
204212
Component {
205213
id: shutdown
206214
Shutdown {}

qml/pages/wallet/DesktopWallets.qml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Page {
2323

2424
signal addWallet()
2525
signal sendTransaction(bool multipleRecipientsEnabled)
26+
signal openSignVerifyMessage(int initialTab)
2627

2728
function handleWalletBadgeActivated() {
2829
if (!walletController.initialized) {
@@ -82,6 +83,12 @@ Page {
8283
onChangePassphraseRequested: {
8384
walletChangePassphrasePopup.openForSelection()
8485
}
86+
onSignMessageRequested: {
87+
root.openSignVerifyMessage(0)
88+
}
89+
onVerifyMessageRequested: {
90+
root.openSignVerifyMessage(1)
91+
}
8592
onCloseWalletRequested: {
8693
walletClosePopup.open()
8794
}

0 commit comments

Comments
 (0)