Skip to content

Commit add5844

Browse files
authored
fix(ci): use actions/upload-artifact@v4 to be compatible with slsa provenance action (#735)
The `slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.0.0` GitHub Action requires `actions/upload-artifact@v4` Action. See the CHANGELOG for more information. Signed-off-by: behnazh <b.hassanshahi@gmail.com>
1 parent 0164233 commit add5844

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/_build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
# Currently reusable workflows do not support setting strategy property from the caller workflow.
135135
- name: Upload the package artifact for debugging and release
136136
if: matrix.os == env.ARTIFACT_OS && matrix.python == env.ARTIFACT_PYTHON
137-
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
137+
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
138138
with:
139139
name: artifact-${{ matrix.os }}-python-${{ matrix.python }}
140140
path: dist

.github/workflows/release.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,6 @@ jobs:
207207
with:
208208
fetch-depth: 0
209209

210-
# Important: update actions/download-artifact to v4 only when generator_generic_slsa3.yml is also compatible.
211-
# See https://github.com/slsa-framework/slsa-github-generator/issues/3068
212210
- name: Download provenance
213211
uses: actions/download-artifact@8caf195ad4b1dee92908e23f56eeb0696f1dd42d # v4.1.5
214212
with:

.github/workflows/scorecards-analysis.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252

5353
# Upload the results as artifacts (optional).
5454
- name: Upload artifact
55-
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
55+
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
5656
with:
5757
name: SARIF file
5858
path: results.sarif

0 commit comments

Comments
 (0)