Skip to content

Commit 22d00bc

Browse files
authored
fix(deps-dev): revert artifact download and upload GitHub Actions to v3 (#686)
The provenance generator GitHub Action `slsa-framework/generator_generic_slsa3.yml` is not compatible with `actions/download-artifact@v4` yet. We need to make sure these two Actions and `actions/upload-artifact` are all compatible. This PR reverts `actions/download-artifact` and `actions/upload-artifact` GitHub Actions to v3. We will update them to v4 when the next version of `generator_generic_slsa3.yml` that will be compatible with `actions/download-artifact@v4` is released. See this relevant `slsa-framework/slsa-github-generator#3068`.
1 parent 92b8656 commit 22d00bc

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/_build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
# Currently reusable workflows do not support setting strategy property from the caller workflow.
135135
- name: Upload the package artifact for debugging and release
136136
if: matrix.os == env.ARTIFACT_OS && matrix.python == env.ARTIFACT_PYTHON
137-
uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595 # v4.1.0
137+
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
138138
with:
139139
name: artifact-${{ matrix.os }}-python-${{ matrix.python }}
140140
path: dist

.github/workflows/_wiki-documentation.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757

5858
# Download the build artifacts attached to this workflow run.
5959
- name: Download artifact
60-
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
60+
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
6161
with:
6262
name: ${{ inputs.artifact-name }}
6363
path: dist

.github/workflows/release.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
fetch-depth: 0
108108

109109
- name: Download artifact
110-
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
110+
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
111111
with:
112112
name: artifact-ubuntu-latest-python-3.11
113113
path: dist
@@ -207,8 +207,10 @@ jobs:
207207
with:
208208
fetch-depth: 0
209209

210+
# Important: update actions/download-artifact to v4 only when generator_generic_slsa3.yml is also compatible.
211+
# See https://github.com/slsa-framework/slsa-github-generator/issues/3068
210212
- name: Download provenance
211-
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
213+
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
212214
with:
213215
name: ${{ needs.provenance.outputs.provenance-name }}
214216

.github/workflows/scorecards-analysis.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252

5353
# Upload the results as artifacts (optional).
5454
- name: Upload artifact
55-
uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595 # v4.1.0
55+
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
5656
with:
5757
name: SARIF file
5858
path: results.sarif

0 commit comments

Comments
 (0)