Skip to content

Commit b6ea05a

Browse files
softinspljones
andauthored
Apply suggestions from code review
Make error messages more descriptive Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
1 parent 22a4293 commit b6ea05a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/socket.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,23 +117,23 @@ void CSocket::Init ( const quint16 iNewPortNumber, const quint16 iNewQosNumber,
117117
const int no = 0;
118118
if ( setsockopt ( UdpSocket, IPPROTO_IPV6, IPV6_V6ONLY, (const char*) &no, sizeof ( no ) ) == -1 )
119119
{
120-
throw CGenErr ( "setsockopt for IPV6_V6ONLY failed", "Network Error" );
120+
throw CGenErr ( "request to support IPv4 over IPv6 failed", "Network Error" );
121121
}
122122

123123
// set the QoS
124124
const int tos = (int) iQosNumber; // Quality of Service
125125
#if !defined( Q_OS_WIN )
126126
if ( setsockopt ( UdpSocket, IPPROTO_IPV6, IPV6_TCLASS, (const char*) &tos, sizeof ( tos ) ) == -1 )
127127
{
128-
throw CGenErr ( "setsockopt for IPV6_TCLASS failed", "Network Error" );
128+
throw CGenErr ( "request to set ToS for IPv6 failed", "Network Error" );
129129
}
130130
#endif
131131

132132
#if !defined( Q_OS_DARWIN )
133133
// set the QoS for IPv4 as well, as this is a dual-protocol socket
134134
if ( setsockopt ( UdpSocket, IPPROTO_IP, IP_TOS, (const char*) &tos, sizeof ( tos ) ) == -1 )
135135
{
136-
throw CGenErr ( "setsockopt for IP_TOS failed", "Network Error" );
136+
throw CGenErr ( "request to set ToS for IPv4 over IPv6 failed", "Network Error" );
137137
}
138138
#endif
139139

@@ -166,7 +166,7 @@ void CSocket::Init ( const quint16 iNewPortNumber, const quint16 iNewQosNumber,
166166
const int tos = (int) iQosNumber; // Quality of Service
167167
if ( setsockopt ( UdpSocket, IPPROTO_IP, IP_TOS, (const char*) &tos, sizeof ( tos ) ) == -1 )
168168
{
169-
throw CGenErr ( "setsockopt for IP_TOS failed", "Network Error" );
169+
throw CGenErr ( "request to set ToS for IPv4 failed", "Network Error" );
170170
}
171171

172172
// preinitialize socket in address (only the port number is missing)

0 commit comments

Comments
 (0)