Skip to content

Commit 16aa570

Browse files
Fix #1622 WhatsThis
As the WhatsThis connections in the clientsettingsdlg to comboboxes and edit fields were all not working they have been moved to the the corresponding labels.
1 parent 192391d commit 16aa570

2 files changed

Lines changed: 16 additions & 10 deletions

File tree

src/clientsettingsdlg.cpp

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP,
111111
ledNetw->setToolTip ( strJitterBufferSizeTT );
112112

113113
// sound card device
114-
cbxSoundcard->setWhatsThis ( "<b>" + tr ( "Sound Card Device" ) + ":</b> " +
114+
lblSoundcardDevice->setWhatsThis ( "<b>" + tr ( "Sound Card Device" ) + ":</b> " +
115115
tr ( "The ASIO driver (sound card) can be selected using " ) + APP_NAME +
116116
tr ( " under the Windows operating system. Under MacOS/Linux, no sound "
117117
"card selection is possible. If the selected ASIO driver is not valid "
@@ -228,11 +228,17 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP,
228228
butDriverSetup->setToolTip ( strSndCardDriverSetupTT );
229229

230230
// fancy skin
231-
cbxSkin->setWhatsThis ( "<b>" + tr ( "Skin" ) + ":</b> " + tr (
231+
lblSkin->setWhatsThis ( "<b>" + tr ( "Skin" ) + ":</b> " + tr (
232232
"Select the skin to be used for the main window." ) );
233233

234234
cbxSkin->setAccessibleName ( tr ( "Skin combo box" ) );
235235

236+
// Interface Language
237+
lblLanguage->setWhatsThis ( "<b>" + tr ( "Language" ) + ":</b> " + tr (
238+
"Select the language to be used for the user interface." ) );
239+
240+
cbxLanguage->setAccessibleName ( tr ( "Language combo box" ) );
241+
236242
// audio channels
237243
QString strAudioChannels = "<b>" + tr ( "Audio Channels" ) + ":</b> " + tr (
238244
"Selects the number of audio channels to be used for communication between "
@@ -460,15 +466,15 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP,
460466
"also be shown at each client which is connected to the same server as "
461467
"you." );
462468

463-
pedtAlias->setWhatsThis ( strFaderTag );
469+
plblAlias->setWhatsThis ( strFaderTag );
464470
pedtAlias->setAccessibleName ( tr ( "Alias or name edit box" ) );
465-
pcbxInstrument->setWhatsThis ( strFaderTag );
471+
plblInstrument->setWhatsThis ( strFaderTag );
466472
pcbxInstrument->setAccessibleName ( tr ( "Instrument picture button" ) );
467-
pcbxCountry->setWhatsThis ( strFaderTag );
473+
plblCountry->setWhatsThis ( strFaderTag );
468474
pcbxCountry->setAccessibleName ( tr ( "Country flag button" ) );
469-
pedtCity->setWhatsThis ( strFaderTag );
475+
plblCity->setWhatsThis ( strFaderTag );
470476
pedtCity->setAccessibleName ( tr ( "City edit box" ) );
471-
pcbxSkill->setWhatsThis ( strFaderTag );
477+
plblSkill->setWhatsThis ( strFaderTag );
472478
pcbxSkill->setAccessibleName ( tr ( "Skill level combo box" ) );
473479

474480
// Instrument pictures combo box -------------------------------------------

src/clientsettingsdlgbase.ui

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
<item>
7979
<layout class="QVBoxLayout" name="verticalLayout_8">
8080
<item>
81-
<widget class="QLabel" name="pedtAlias_2">
81+
<widget class="QLabel" name="plblAlias">
8282
<property name="text">
8383
<string>Alias/Name</string>
8484
</property>
@@ -203,14 +203,14 @@
203203
<item>
204204
<layout class="QVBoxLayout" name="verticalLayout_5">
205205
<item>
206-
<widget class="QLabel" name="lblSkin_2">
206+
<widget class="QLabel" name="lblSkin">
207207
<property name="text">
208208
<string>Skin</string>
209209
</property>
210210
</widget>
211211
</item>
212212
<item>
213-
<widget class="QLabel" name="lblLanguage_2">
213+
<widget class="QLabel" name="lblLanguage">
214214
<property name="text">
215215
<string>Language</string>
216216
</property>

0 commit comments

Comments
 (0)