You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #226 unified click semantics for the map dot and samples table surfaces: click = open detail card; the external link to the source record lives inside the card, never as the default action. The fix shipped alongside the in-map detail card build.
Per Codex's review of the #226 PR, two other surfaces in explorer.qmd still render the old pattern — they emit an <a href={sourceUrl(pid)}> for the sample label and bail row-clicks on anchor targets, so clicking the title navigates externally instead of opening the card.
If we're serious about uniform click semantics, these need the same treatment.
Surfaces still inconsistent
1. Nearby-samples panel (updateSamples())
explorer.qmd lines ~1268-1271 — rendered in the side panel when a cluster is clicked.
Click on the title → opens external. Click elsewhere → no row activation at all (this panel has no row click handler today — selecting a nearby sample requires going through some other path).
2. Search results panel
explorer.qmd around lines 3284-3303 — list of search hits. Renders `` for each hit and explicitly returns on anchor clicks in the row handler.
```js
if (e.target.tagName === 'A') return; // let label links work
```
Same bleed-through pattern as the table-row case fixed in #226.
The nearby-samples panel needs an additional design decision: it currently has no row-click handler. Activating a nearby sample is a small UX feature, not just a code refactor.
The search-results panel rendering lives in a different OJS cell — a clean separate PR keeps the diff comprehensible.
Background
Issue #226 unified click semantics for the map dot and samples table surfaces: click = open detail card; the external link to the source record lives inside the card, never as the default action. The fix shipped alongside the in-map detail card build.
Per Codex's review of the #226 PR, two other surfaces in
explorer.qmdstill render the old pattern — they emit an<a href={sourceUrl(pid)}>for the sample label and bail row-clicks on anchor targets, so clicking the title navigates externally instead of opening the card.If we're serious about uniform click semantics, these need the same treatment.
Surfaces still inconsistent
1. Nearby-samples panel (
updateSamples())explorer.qmdlines ~1268-1271 — rendered in the side panel when a cluster is clicked.```js
const sUrl = sourceUrl(s.pid);
h += `<div class="sample-row">
...
${sUrl ? `<a class="sample-label" href="${sUrl}" ... >${...}` : ...}
```
Click on the title → opens external. Click elsewhere → no row activation at all (this panel has no row click handler today — selecting a nearby sample requires going through some other path).
2. Search results panel
explorer.qmdaround lines 3284-3303 — list of search hits. Renders `` for each hit and explicitly returns on anchor clicks in the row handler.```js
if (e.target.tagName === 'A') return; // let label links work
```
Same bleed-through pattern as the table-row case fixed in #226.
Scope for this issue
Apply the #226 pattern uniformly:
Why a separate PR
Related