work around the fact we can't render items anymore

Author: isXander

src/main/java/dev/isxander/yacl3/gui/controllers/dropdown/ItemControllerElement.java

@@ -32,7 +32,12 @@ protected void drawValueText(GuiGraphicsExtractor graphics, int mouseX, int mous
 		super.drawValueText(graphics, mouseX, mouseY, delta);
 		setDimension(oldDimension);
 		if (currentItem != null) {
-			graphics.fakeItem(new ItemStack(currentItem), getDimension().xLimit() - getXPadding() - getDecorationPadding() + 2, getDimension().y() + 2);
+            renderFakeItem(
+                    graphics,
+                    currentItem,
+                    getDimension().xLimit() - getXPadding() - getDecorationPadding() + 2,
+                    getDimension().y() + 2
+            );
 		}
 	}
 
@@ -49,13 +54,27 @@ public List<Identifier> computeMatchingValues() {
 	@Override
 	protected void renderDropdownEntry(GuiGraphicsExtractor graphics, Dimension<Integer> entryDimension, Identifier identifier) {
 		super.renderDropdownEntry(graphics, entryDimension, identifier);
-		graphics.fakeItem(
-				new ItemStack(matchingItems.get(identifier)),
-				entryDimension.xLimit() - 2,
-				entryDimension.y() + 1
-		);
+        renderFakeItem(
+                graphics,
+                matchingItems.get(identifier),
+                entryDimension.xLimit() - 2,
+                entryDimension.y() + 1
+        );
 	}
 
+    private void renderFakeItem(GuiGraphicsExtractor graphics, Item item, int x, int y) {
+        ItemStack stack = null;
+        try {
+            stack = new ItemStack(item);
+        } catch (NullPointerException ignored) {
+            // ItemStacks no longer exist until dynamic registries have been loaded,
+            // which is either loading into a level or opening the create world screen.
+            // This means we cannot do anything that involves ItemStacks until then.
+        }
+        if (stack == null) return;
+        graphics.fakeItem(stack, x, y);
+    }
+
 	@Override
 	public String getString(Identifier identifier) {
 		return identifier.toString();
@@ -85,6 +104,17 @@ protected Component getValueText() {
 			return Component.literal(inputField);
 
         Item item = itemController.option().pendingValue();
-		return item.getName(item.getDefaultInstance());
+        ItemStack stack = null;
+        try {
+            stack = item.getDefaultInstance();
+        } catch (NullPointerException ignored) {
+            // fapi has a bug (i think) that doesn't bind item components early enough anymore,
+            // causing an NPE on <init> of ItemStack.
+        }
+        if (stack != null) {
+            return item.getName(stack);
+        } else {
+            return Component.literal(item.toString());
+        }
 	}
 }

stonecutter.gradle.kts

@@ -5,6 +5,7 @@ plugins {
 
     val modstitchVersion = "0.8.4"
     id("dev.isxander.modstitch.base") version modstitchVersion apply false
+    id("net.fabricmc.fabric-loom") version "1.15-SNAPSHOT" apply false
 
     id("me.modmuss50.mod-publish-plugin") version "0.8.4" apply false
     id("org.ajoberstar.grgit") version "5.0.+" apply false

versions/26.1-fabric/gradle.properties

@@ -2,7 +2,7 @@ modstitch.platform=fabric-loom
 
 mcVersion=26.1-pre-1
 
-deps.fabricApi=0.143.11+26.1
+deps.fabricApi=0.143.12+26.1
 
 meta.mcDep=^26.1-