Skip to content

Commit a257e92

Browse files
committed
make cache_requests be a eval_config
Signed-off-by: Oleg Silkin <97077423+RobotSail@users.noreply.github.com>
1 parent bd95672 commit a257e92

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

src/instructlab/eval/leaderboard.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ class TaskGrouping(t.TypedDict):
7575
"confirm_run_unsafe_code": True,
7676
"max_model_len": 32768,
7777
"system_instruction": None,
78+
"cache_requests": False,
7879
}
7980

8081
# Default backend-specific configuration parameters
@@ -88,7 +89,6 @@ class TaskGrouping(t.TypedDict):
8889
DEFAULT_HF_CONFIG = {
8990
"dtype": "float16",
9091
"trust_remote_code": True,
91-
"cache_requests": True,
9292
}
9393

9494
# generative tasks go here
@@ -560,6 +560,7 @@ def __init__(
560560
- confirm_run_unsafe_code: True - Whether to run potentially unsafe code without confirmation
561561
- max_model_len: 32768 - Maximum sequence length for the model
562562
- system_instruction: None - Optional system instruction to prepend to prompts
563+
- cache_requests: False - Whether to cache requests for the dataset
563564
vllm_config: Configuration for vLLM-specific parameters.
564565
Default values (can be overridden):
565566
- dtype: "float16" - Data type for model weights
@@ -571,7 +572,6 @@ def __init__(
571572
Default values (can be overridden):
572573
- dtype: "float16" - Data type for model weights
573574
- trust_remote_code: True - Whether to trust remote code in model loading
574-
- cache_requests: True - Whether to cache requests
575575
And any other HuggingFace parameters supported by simple_evaluate.
576576
"""
577577
self.model_path = model_path
@@ -675,7 +675,6 @@ def run(
675675
Default values (can be overridden):
676676
- dtype: "float16" - Data type for model weights
677677
- trust_remote_code: True - Whether to trust remote code in model loading
678-
- cache_requests: True - Whether to cache requests
679678
And any other HuggingFace parameters supported by simple_evaluate.
680679
681680
Returns:

0 commit comments

Comments
 (0)