Skip to content

Commit eac1270

Browse files
committed
fix: SonarQube reliability issues.
- Fixed in `src/instana/instrumentation/aws/boto3.py`: - Low reliability issue **Function parameters initial values should not be ignored.** - Fixed in `src/instana/instrumentation/tornado/client.py`: - Medium reliability issue **All "except" blocks should be able to catch exceptions.** Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
1 parent 71b1c04 commit eac1270

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

src/instana/instrumentation/aws/boto3.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
from instana.log import logger
2525
from instana.propagators.format import Format
26-
from instana.singletons import get_tracer
2726
from instana.util.traceutils import extract_custom_headers, get_tracer_tuple
2827

2928
def lambda_inject_context(
@@ -37,7 +36,6 @@ def lambda_inject_context(
3736
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/lambda.html#Lambda.Client.invoke
3837
"""
3938
try:
40-
tracer = get_tracer()
4139
invoke_payload = payload.get("Payload", {})
4240

4341
if not isinstance(invoke_payload, dict):

src/instana/instrumentation/tornado/client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,5 +102,3 @@ def finish_tracing(future: "Future", span: "InstanaSpan") -> None:
102102
logger.debug("Instrumenting tornado client")
103103
except ImportError:
104104
pass
105-
except ImportError:
106-
pass

0 commit comments

Comments
 (0)