Skip to content

Commit c8f1914

Browse files
Hongyan JiangGitHub Enterprise
authored andcommitted
rename HTTPURLResponse backendTracingID to serverTimingTraceId (#86)
1 parent 946d795 commit c8f1914

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

Sources/InstanaAgent/Monitors/HTTP/HTTPMarker.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ protocol HTTPMarkerDelegate: AnyObject {
111111
}
112112

113113
let result = HTTPCaptureResult(statusCode: statusCode,
114-
backendTracingID: tracestate ?? response?.backendTracingID,
114+
backendTracingID: tracestate ?? response?.serverTimingTraceId,
115115
header: bothHeaders,
116116
responseSize: responseSize ?? size,
117117
error: error)

Sources/InstanaAgent/Utils/Extensions/URLResponse+URLRequest+Helper.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ extension URLResponse {
1010
let value: String
1111
}
1212

13-
var backendTracingID: String? {
13+
var serverTimingTraceId: String? {
1414
guard let httpResponse = self as? HTTPURLResponse,
1515
let servertiming = httpResponse.value(for: "Server-Timing")
1616
else { return nil }

Tests/InstanaAgentTests/Utils_Tests/Extensions/URLResponseHeaderFieldsTests.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
1616
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
1717

1818
// When
19-
let sut = httpResponse?.backendTracingID
19+
let sut = httpResponse?.serverTimingTraceId
2020

2121
// Then
2222
AssertEqualAndNotNil(sut, backendTracingID)
@@ -29,7 +29,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
2929
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
3030

3131
// When
32-
let sut = httpResponse?.backendTracingID
32+
let sut = httpResponse?.serverTimingTraceId
3333

3434
// Then
3535
AssertEqualAndNotNil(sut, backendTracingID)
@@ -42,7 +42,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
4242
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
4343

4444
// When
45-
let sut = httpResponse?.backendTracingID
45+
let sut = httpResponse?.serverTimingTraceId
4646

4747
// Then
4848
AssertEqualAndNotNil(sut, backendTracingID)
@@ -56,7 +56,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
5656
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
5757

5858
// When
59-
let sut = httpResponse?.backendTracingID
59+
let sut = httpResponse?.serverTimingTraceId
6060

6161
// Then
6262
AssertEqualAndNotNil(sut, backendTracingID2)
@@ -69,7 +69,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
6969
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
7070

7171
// When
72-
let sut = httpResponse?.backendTracingID
72+
let sut = httpResponse?.serverTimingTraceId
7373

7474
// Then
7575
XCTAssertNil(sut)
@@ -82,7 +82,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
8282
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
8383

8484
// When
85-
let sut = httpResponse?.backendTracingID
85+
let sut = httpResponse?.serverTimingTraceId
8686

8787
// Then
8888
XCTAssertNil(sut)
@@ -95,7 +95,7 @@ class URLResponseHeaderFieldsTests: InstanaTestCase {
9595
let httpResponse = HTTPURLResponse(url: URL.random, statusCode: 200, httpVersion: "1.1", headerFields: headerFields)
9696

9797
// When
98-
let sut = httpResponse?.backendTracingID
98+
let sut = httpResponse?.serverTimingTraceId
9999

100100
// Then
101101
XCTAssertNil(sut)

0 commit comments

Comments
 (0)