More code cleanup

Author: ctmay4

src/main/java/com/imsweb/seerapi/client/mph/MphRule.java

@@ -22,9 +22,6 @@ public class MphRule {
     @JsonProperty("examples")
     private List<String> _examples;
 
-    public MphRule() {
-    }
-
     public String getGroupId() {
         return _groupId;
     }

src/main/java/com/imsweb/seerapi/client/naaccr/NaaccrXmlField.java

@@ -39,9 +39,6 @@ public class NaaccrXmlField {
     @JsonProperty("documentation")
     protected String _documentation;
 
-    public NaaccrXmlField() {
-    }
-
     public String getNaaccrId() {
         return _naaccrId;
     }

src/main/java/com/imsweb/seerapi/client/ndc/NdcSearch.java

@@ -115,7 +115,7 @@ public Map<String, String> paramMap() {
         if (getHasSeerInfo() != null)
             params.put("has_seer_info", getHasSeerInfo().toString());
         if (getIncludeRemoved() != null)
-            params.put("include_removed", getIncludeRemoved() ? "true" : "false");
+            params.put("include_removed", Boolean.TRUE.equals(getIncludeRemoved()) ? "true" : "false");
         if (getAddedSince() != null)
             params.put("added_since", getAddedSince());
         if (getModifiedSince() != null)

src/main/java/com/imsweb/seerapi/client/publishable/PublishableChangelogResults.java

@@ -11,12 +11,6 @@ public class PublishableChangelogResults {
     protected Integer _count;
     protected Integer _offset;
 
-    /**
-     * Default constructor
-     */
-    public PublishableChangelogResults() {
-    }
-
     @JsonProperty("total")
     public Long getTotal() {
         return _total;

src/main/java/com/imsweb/seerapi/client/rx/Rx.java

@@ -40,12 +40,6 @@ public class Rx extends Publishable {
     @JsonProperty("radiation")
     protected String _radiation;
 
-    /**
-     * Default constructor
-     */
-    public Rx() {
-    }
-
     public List<RxHistoryEvent> getHistory() {
         return _history;
     }

src/main/java/com/imsweb/seerapi/client/rx/RxChangelogResults.java

@@ -13,12 +13,6 @@ public class RxChangelogResults extends PublishableChangelogResults {
 
     protected List<RxChangelog> _changelogs;
 
-    /**
-     * Default constructor
-     */
-    public RxChangelogResults() {
-    }
-
     @JsonProperty("changelogs")
     public List<RxChangelog> getChangelogs() {
         return _changelogs;

src/main/java/com/imsweb/seerapi/client/staging/SchemaLookup.java

@@ -3,6 +3,7 @@
  */
 package com.imsweb.seerapi.client.staging;
 
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -41,7 +42,7 @@ public SchemaLookup(String site, String histology) {
      * @return a set of keys
      */
     public Set<String> getAllowedKeys() {
-        return null;
+        return Collections.emptySet();
     }
 
     /**
@@ -116,6 +117,7 @@ public void setHistology(String hist) {
      * Return true if the inputs contain a discriminator.  A key that is not site or hist which has a non-null/non-empty value is considered a discriminator
      * @return true or false indicating whether a discriminator exists
      */
+    @SuppressWarnings("java:S135")
     public boolean hasDiscriminator() {
         boolean hasDiscriminator = false;
 

src/main/java/com/imsweb/seerapi/client/staging/StagingMetadataDeserializer.java

@@ -3,7 +3,6 @@
 import java.io.IOException;
 
 import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
@@ -19,7 +18,7 @@ protected StagingMetadataDeserializer(Class<?> vc) {
     }
 
     @Override
-    public StagingMetadata deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException, JsonProcessingException {
+    public StagingMetadata deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException {
         JsonNode node = jp.getCodec().readTree(jp);
 
         if (node.isNull())

src/main/java/com/imsweb/seerapi/client/staging/StagingSchema.java

@@ -46,9 +46,6 @@ public enum StagingInputErrorHandler {
     private Set<String> _involvedTables;
     private StagingInputErrorHandler _onInvalidInput;
 
-    public StagingSchema() {
-    }
-
     @JsonProperty("id")
     public String getId() {
         return _displayId;

src/main/java/com/imsweb/seerapi/client/staging/StagingTable.java

@@ -27,9 +27,6 @@ public class StagingTable {
     private Set<String> _extraInput;
     private List<List<String>> _rows;
 
-    public StagingTable() {
-    }
-
     @JsonProperty("id")
     public String getId() {
         return _displayId;