Merge pull request #35 from imsweb/sonarqube-fixes

Sonarqube fixes

Author: ctmay4

.github/workflows/integration.yml

@@ -12,6 +12,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
       - name: Set up JDK
         uses: actions/setup-java@v2
         with:

src/main/java/com/imsweb/seerapi/client/disease/DateRange.java

@@ -9,12 +9,6 @@ public class DateRange {
     @JsonProperty("end")
     protected String _endDate;
 
-    /**
-     * Default constructor
-     */
-    public DateRange() {
-    }
-
     public String getStartDate() {
         return _startDate;
     }

src/main/java/com/imsweb/seerapi/client/disease/DateRangeString.java

@@ -7,12 +7,6 @@ public class DateRangeString extends DateRange {
     @JsonProperty("value")
     protected String _value;
 
-    /**
-     * Default constructor
-     */
-    public DateRangeString() {
-    }
-
     public String getValue() {
         return _value;
     }

src/main/java/com/imsweb/seerapi/client/disease/DiseaseChangelogResults.java

@@ -13,12 +13,6 @@ public class DiseaseChangelogResults extends PublishableChangelogResults {
 
     protected List<DiseaseChangelog> _changelogs;
 
-    /**
-     * Default constructor
-     */
-    public DiseaseChangelogResults() {
-    }
-
     @JsonProperty("changelogs")
     public List<DiseaseChangelog> getChangelogs() {
         return _changelogs;

src/main/java/com/imsweb/seerapi/client/glossary/GlossaryChangelogResults.java

@@ -13,12 +13,6 @@ public class GlossaryChangelogResults extends PublishableChangelogResults {
 
     protected List<GlossaryChangelog> _changelogs;
 
-    /**
-     * Default constructor
-     */
-    public GlossaryChangelogResults() {
-    }
-
     @JsonProperty("changelogs")
     public List<GlossaryChangelog> getChangelogs() {
         return _changelogs;

src/main/java/com/imsweb/seerapi/client/mph/MphOutput.java

@@ -16,8 +16,6 @@ public class MphOutput {
     private String _groupId;
     @JsonProperty("step")
     private String _step;
-    public MphOutput() {
-    }
 
     public Result getResult() {
         return _result;

src/main/java/com/imsweb/seerapi/client/mph/MphRule.java

@@ -22,9 +22,6 @@ public class MphRule {
     @JsonProperty("examples")
     private List<String> _examples;
 
-    public MphRule() {
-    }
-
     public String getGroupId() {
         return _groupId;
     }

src/main/java/com/imsweb/seerapi/client/naaccr/NaaccrXmlField.java

@@ -39,9 +39,6 @@ public class NaaccrXmlField {
     @JsonProperty("documentation")
     protected String _documentation;
 
-    public NaaccrXmlField() {
-    }
-
     public String getNaaccrId() {
         return _naaccrId;
     }

src/main/java/com/imsweb/seerapi/client/ndc/NdcSearch.java

@@ -115,7 +115,7 @@ public Map<String, String> paramMap() {
         if (getHasSeerInfo() != null)
             params.put("has_seer_info", getHasSeerInfo().toString());
         if (getIncludeRemoved() != null)
-            params.put("include_removed", getIncludeRemoved() ? "true" : "false");
+            params.put("include_removed", Boolean.TRUE.equals(getIncludeRemoved()) ? "true" : "false");
         if (getAddedSince() != null)
             params.put("added_since", getAddedSince());
         if (getModifiedSince() != null)

src/main/java/com/imsweb/seerapi/client/publishable/PublishableChangelogResults.java

@@ -11,12 +11,6 @@ public class PublishableChangelogResults {
     protected Integer _count;
     protected Integer _offset;
 
-    /**
-     * Default constructor
-     */
-    public PublishableChangelogResults() {
-    }
-
     @JsonProperty("total")
     public Long getTotal() {
         return _total;