Merge pull request #203 from karczewskiPiotr/fix-matrix-toArray

Fix Matrix.toArray

Author: iddan

src/matrix.test.ts

@@ -177,9 +177,32 @@ describe("Matrix.toArray()", () => {
     ...EXAMPLE_MATRIX[1],
     ...EXAMPLE_MATRIX[2],
   ];
-  test("Flattens matrix values to an array", () => {
+  test("Flattens square matrix values to an array", () => {
     expect(Matrix.toArray(EXAMPLE_MATRIX)).toEqual(flattedMatrix);
   });
+  test("Flattens horizontal matrix values to an array", () => {
+    expect(
+      Matrix.toArray([
+        [1, 2, 3],
+        [4, 5, 6],
+      ])
+    ).toEqual([1, 2, 3, 4, 5, 6]);
+  });
+  test("Flattens vertical matrix values to an array", () => {
+    expect(
+      Matrix.toArray([
+        [1, 2],
+        [3, 4],
+        [5, 6],
+      ])
+    ).toEqual([1, 2, 3, 4, 5, 6]);
+  });
+  test("Flattens column matrix values to an array", () => {
+    expect(Matrix.toArray([[1], [2], [3]])).toEqual([1, 2, 3]);
+  });
+  test("Flattens row matrix values to an array", () => {
+    expect(Matrix.toArray([[1, 2, 3]])).toEqual([1, 2, 3]);
+  });
   test("Transforms matrix values and collects them to an array", () => {
     const transform = (value: number | undefined) => value && value * 2;
     expect(

src/matrix.ts

@@ -236,7 +236,7 @@ export function toArray<T1, T2>(
 ) {
   const array = [];
   for (let row = 0; row < matrix.length; row++) {
-    for (let column = 0; column < matrix.length; column++) {
+    for (let column = 0; column < matrix[row].length; column++) {
       const value = matrix[row][column];
       array.push(transform ? transform(value, { row, column }) : value);
     }