Merge pull request #1254 from GrahamTheCoder/claude/fix-issue-1012-lambda-multiline

Fix conversion of single-statement multiline lambda to block syntax

Author: GrahamTheCoder

CodeConverter/CSharp/LambdaConverter.cs

@@ -80,8 +80,17 @@ public async Task<CSharpSyntaxNode> ConvertAsync(VBSyntax.LambdaExpressionSyntax
             convertedStatements = convertedStatements.Select(l => l.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed)).ToList();
             block = SyntaxFactory.Block(convertedStatements);
         } else if (singleStatement.TryUnpackSingleExpressionFromStatement(out expressionBody)) {
-            arrow = SyntaxFactory.ArrowExpressionClause(expressionBody);
+            if (vbNode is VBasic.Syntax.MultiLineLambdaExpressionSyntax && singleStatement is not ExpressionStatementSyntax && singleStatement is not ReturnStatementSyntax) {
+                singleStatement = singleStatement.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed);
+                block = SyntaxFactory.Block(singleStatement);
+                expressionBody = null;
+            } else {
+                arrow = SyntaxFactory.ArrowExpressionClause(expressionBody);
+            }
         } else {
+            if (vbNode is VBasic.Syntax.MultiLineLambdaExpressionSyntax) {
+                singleStatement = singleStatement.WithTrailingTrivia(SyntaxFactory.ElasticCarriageReturnLineFeed);
+            }
             block = SyntaxFactory.Block(singleStatement);
         }
 

Tests/CSharp/ExpressionTests/LambdaTests.cs

@@ -0,0 +1,56 @@
+using System.Threading.Tasks;
+using ICSharpCode.CodeConverter.Tests.TestRunners;
+using Xunit;
+
+namespace ICSharpCode.CodeConverter.Tests.CSharp.ExpressionTests;
+
+public class LambdaTests : ConverterTestBase
+{
+    [Fact]
+    public async Task Issue1012_MultiLineLambdaWithSingleStatement()
+    {
+        await TestConversionVisualBasicToCSharpAsync(@"Imports System.Collections.Generic
+Imports System.Linq
+Imports System.Threading.Tasks
+
+Public Class ConversionTest3
+    Private Class MyEntity
+        Property EntityId As Integer
+        Property Name As String
+    End Class
+    Private Sub BugRepro()
+
+        Dim entities As New List(Of MyEntity)
+
+        Parallel.For(1, 3, Sub(i)
+                               Dim result As String = (From e In entities
+                                                       Where e.EntityId = 123
+                                                       Select e.Name).Single
+                           End Sub)
+    End Sub
+End Class", @"using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+
+public partial class ConversionTest3
+{
+    private partial class MyEntity
+    {
+        public int EntityId { get; set; }
+        public string Name { get; set; }
+    }
+    private void BugRepro()
+    {
+
+        var entities = new List<MyEntity>();
+
+        Parallel.For(1, 3, i =>
+        {
+            string result = (from e in entities
+                             where e.EntityId == 123
+                             select e.Name).Single();
+        });
+    }
+}");
+    }
+}

Tests/CSharp/StatementTests/MethodStatementTests.cs

@@ -1581,7 +1581,10 @@ private int FuncReturningZero()
     private int FuncReturningAssignedValue()
     {
         int FuncReturningAssignedValueRet = default;
-        void aSub(object y) { return; };
+        void aSub(object y)
+        {
+            return;
+        };
         FuncReturningAssignedValueRet = 3;
         return FuncReturningAssignedValueRet;
     }