Skip to content

Commit fdf6e60

Browse files
iccoclaude
andauthored
fix: exclude vendored link/ trees from yamllint and yq formatting (#23)
CI's `yaml-lint` job has been failing on every push to main. All 36 yamllint findings are in vendored upstream code (`link/oh-my-zsh/`, `link/vim/bundle/`), which overflows reviewdog's annotation limit — the step exits non-zero with `reviewdog: Too many results (annotations) in diff`. - `.yamllint.yml`: `ignore: link/`. Nothing under `link/` is ours (our 7 YAML files are at the root and under `.github/`), and these trees get re-vendored on every `task vim` / omz update, so a prefix beats enumerating today's offenders. - `ci.yml`: the yq format step only excluded `link/vim/bundle`, so the first *successful* run would have `yq -iP`'d every vendored oh-my-zsh and `link/vim/pack` file and pushed a bot commit rewriting them. Excluded `link/` there and in the auto-commit `file_pattern`. Verified locally with the same yamllint (1.38.0) and the same invocation CI uses: `yamllint .` prints nothing, down from 36 problems. Also simulated the yq step on our own files — no diffs, so the auto-commit stays a no-op. Note: the PR check runs with `filter_mode: added`, so it will go green regardless; the real confirmation is the post-merge push run. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 667c935 commit fdf6e60

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,16 @@ jobs:
6161
uses: dcarbone/install-yq-action@v1.3.1
6262
- name: Format YAML files with yq
6363
run: |
64-
# Format all YAML files in place, excluding vim bundles
65-
find . -name "*.yml" -o -name "*.yaml" | grep -v "link/vim/bundle" | while read -r file; do
64+
# Format all YAML files in place, excluding vendored trees under link/
65+
find . -name "*.yml" -o -name "*.yaml" | grep -v "^./link/" | while read -r file; do
6666
echo "Formatting $file"
6767
yq -iP '.' "$file"
6868
done
6969
- name: Commit YAML formatting changes
7070
uses: stefanzweifel/git-auto-commit-action@v7
7171
with:
7272
commit_message: 'feat: format YAML files with yq'
73-
file_pattern: '*.yml *.yaml :!.github/workflows/*'
73+
file_pattern: '*.yml *.yaml :!.github/workflows/* :!link/*'
7474
commit_author: GitHub Actions <actions@github.com>
7575
commit_user_name: github-actions[bot]
7676
commit_user_email: github-actions[bot]@users.noreply.github.com

‎.yamllint.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
extends: default
2+
# Everything under link/ is vendored upstream (oh-my-zsh, vim plugins).
3+
ignore: |
4+
link/
25
rules:
36
line-length: disable
47
document-start: disable

0 commit comments

Comments
 (0)