Skip to content

Commit ebd3769

Browse files
committed
Explicitly initialize gpsState.hwVersion to 0 in gpsInit()
Addresses Qodo code review suggestion to prevent sending uninitialized memory over MSP_GPSSTATISTICS. While global variables are zero-initialized in C, explicit initialization is better practice: - Makes intent clear in code - Works for all GPS providers (UBLOX, MSP, FAKE) - Future-proof if gpsState becomes non-global - Documents that 0 means UNKNOWN u-blox driver also initializes to UBX_HW_VERSION_UNKNOWN (0) during configuration, but this ensures all code paths are safe.
1 parent dda5ffd commit ebd3769

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/main/io/gps.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,9 @@ void gpsInit(void)
451451
gpsStats.errors = 0;
452452
gpsStats.timeouts = 0;
453453

454+
// Initialize hardware version to unknown (for MSP_GPSSTATISTICS)
455+
gpsState.hwVersion = 0;
456+
454457
// Reset solution, timeout and prepare to start
455458
gpsResetSolution(&gpsSolDRV);
456459
gpsResetSolution(&gpsSol);

0 commit comments

Comments
 (0)