Commit f89f2be
committed
Address review feedback: unsigned shift and error handling
Use unsigned right-shift (>>>) for bitmask checks to avoid
sign-extension issues when bit 31 is set. Use MSP.promise() with
.catch() so done() is always called even if the mask fetch fails.1 parent d606a4c commit f89f2be
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2437 | 2437 | | |
2438 | 2438 | | |
2439 | 2439 | | |
2440 | | - | |
| 2440 | + | |
| 2441 | + | |
| 2442 | + | |
| 2443 | + | |
2441 | 2444 | | |
2442 | 2445 | | |
2443 | 2446 | | |
| |||
4181 | 4184 | | |
4182 | 4185 | | |
4183 | 4186 | | |
4184 | | - | |
4185 | | - | |
| 4187 | + | |
| 4188 | + | |
4186 | 4189 | | |
4187 | 4190 | | |
4188 | 4191 | | |
| |||
0 commit comments