Adding unit tests

Author: hummeltech

src/CMakeLists.txt

@@ -327,4 +327,23 @@ target_compile_definitions(unit_test_renderd_config PRIVATE
 target_include_directories(unit_test_renderd_config PRIVATE ${PROJECT_SOURCE_DIR}/src ${PROJECT_SOURCE_DIR}/tests)
 target_link_libraries(unit_test_renderd_config ${unit_test_renderd_config_LIBS})
 
+
+#-----------------------------------------------------------------------------
+#
+#  unit_test_sys_utils
+#
+#-----------------------------------------------------------------------------
+
+set(unit_test_sys_utils_SRCS
+  $<TARGET_OBJECTS:catch_main_o>
+  ${PROJECT_SOURCE_DIR}/tests/unit_test_sys_utils.cpp
+)
+set(unit_test_sys_utils_LIBS
+  ${GLIB_LIBRARIES}
+)
+add_executable(unit_test_sys_utils ${unit_test_sys_utils_SRCS})
+set_target_properties(unit_test_sys_utils PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/tests)
+target_include_directories(unit_test_sys_utils PRIVATE ${PROJECT_SOURCE_DIR}/src ${PROJECT_SOURCE_DIR}/tests)
+target_link_libraries(unit_test_sys_utils ${unit_test_sys_utils_LIBS})
+
 endif()

tests/CMakeLists.txt

@@ -245,6 +245,11 @@ add_test(
   COMMAND unit_test_renderd_config
 )
 
+add_test(
+  NAME unit_test_sys_utils
+  COMMAND unit_test_sys_utils
+)
+
 foreach(STORAGE_BACKEND_INDEX RANGE ${STORAGE_BACKENDS_LENGTH})
   # Get STORAGE_BACKEND from STORAGE_BACKENDS list
   list(GET STORAGE_BACKENDS ${STORAGE_BACKEND_INDEX} STORAGE_BACKEND)

tests/catch_test_common.cpp

@@ -44,6 +44,7 @@ bool fail_next_asprintf = false;
 bool fail_next_connect = false;
 bool fail_next_getaddrinfo = false;
 bool fail_next_getaddrinfo_empty_res = false;
+bool fail_next_getloadavg = false;
 bool fail_next_malloc = false;
 bool fail_next_mkdir = false;
 bool fail_next_open = false;
@@ -156,7 +157,6 @@ void start_capture(bool debug)
 		setenv("G_MESSAGES_DEBUG", "all", 1);
 #if GLIB_MAJOR_VERSION == 2 && GLIB_MINOR_VERSION >= 79
 		// https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3710
-		std::cout << "Resetting G_MESSAGES_DEBUG env var in runtime no longer has an effect.\n";
 		const gchar *domains[] = {"all", NULL};
 		g_log_writer_default_set_debug_domains(domains);
 #endif
@@ -170,6 +170,7 @@ std::tuple<std::string, std::string> end_capture(bool print)
 {
 	setenv("G_MESSAGES_DEBUG", "", 1);
 #if GLIB_MAJOR_VERSION == 2 && GLIB_MINOR_VERSION >= 79
+	// https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3710
 	g_log_writer_default_set_debug_domains(NULL);
 #endif
 	foreground = 0;
@@ -343,6 +344,16 @@ extern "C" {
 		return getaddrinfo(node, service, hints, res);
 	}
 
+	int mocked_getloadavg(double loadavg[], int nelem)
+	{
+		if (fail_next_getloadavg) {
+			fail_next_getloadavg = false;
+			return -1;
+		}
+
+		return getloadavg(loadavg, nelem);
+	}
+
 	void *mocked_malloc(size_t size)
 	{
 		if (fail_next_malloc) {

tests/catch_test_common.hpp

@@ -55,6 +55,7 @@ extern "C" {
 	int mocked_asprintf(char **strp, const char *fmt, ...);
 	int mocked_connect(int sockfd, const struct sockaddr *addr, socklen_t addrlen);
 	int mocked_getaddrinfo(const char *node, const char *service, const struct addrinfo *hints, struct addrinfo **res);
+	int mocked_getloadavg(double loadavg[], int nelem);
 	void *mocked_malloc(size_t size);
 	int mocked_mkdir(const char *path, mode_t mode);
 	int mocked_open(const char *pathname, int flags, ...);

tests/unit_test_sys_utils.cpp

@@ -0,0 +1,42 @@
+#include <fcntl.h>
+#include <stdlib.h>
+#include <string>
+#include <unistd.h>
+
+#include "catch/catch.hpp"
+#include "catch_test_common.hpp"
+#include "sys_utils.h"
+
+extern bool fail_next_getloadavg;
+extern std::string err_log_lines;
+
+#define g_logger mocked_g_logger
+#define getloadavg mocked_getloadavg
+
+#include "sys_utils.c"
+
+#undef g_logger
+#undef getloadavg
+
+TEST_CASE("get_load_avg function", "[get_load_avg]")
+{
+	err_log_lines.clear();
+
+	SECTION("get_load_avg", "should return positive") {
+		double loadavg = get_load_avg();
+
+		REQUIRE(loadavg > 0);
+	}
+
+	SECTION("get_load_avg with unobtainable load average", "should return 1000") {
+		fail_next_getloadavg = true;
+
+		double loadavg = get_load_avg();
+
+#ifdef HAVE_GETLOADAVG
+		REQUIRE(loadavg == 1000);
+#else
+		REQUIRE(loadavg > 0);
+#endif
+	}
+}