BUG: Logic bug in contenating strings.

PythonQt/generator/main.cpp:98:60: warning: adding 'bool' to a string does not append to the string [-Wstring-plus-int]
        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
PythonQt/generator/main.cpp:98:60: note: use array indexing to silence this warning
        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?
                                                           ^
                         &                                 [                ]
PythonQt/generator/main.cpp:98:78: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]
        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
PythonQt/generator/main.cpp:98:78: note: place parentheses around the '+' expression to silence this warning
        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?
                                                                             ^
                         (                                                  )
PythonQt/generator/main.cpp:98:78: note: place parentheses around the '?:' expression to evaluate it first
        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?

Author: hjmjohnson

generator/main.cpp

@@ -95,8 +95,10 @@ namespace
       QString qtdir = getenv("QTDIR");
       if (qtdir.isEmpty() || !QDir(qtdir).exists(qtdir))
       {
-        QString reason = "The QTDIR environment variable " + qtdir.isEmpty() ?
-                         "is not set. " : "points to a non-existing directory. ";
+        const QString prefix = "The QTDIR environment variable " ;
+        const QString reason = qtdir.isEmpty()
+                         ? prefix + "is not set. "
+                         : prefix + "points to a non-existing directory. ";
 #if defined(Q_OS_MAC)
         qWarning() << reason << "Assuming standard binary install using frameworks.";
             QString frameworkDir = "/Library/Frameworks";