Enable -Wall and a few other warnings in cabal file. Fix warnings, cleanup cabal file

Author: sergv

src/Data/Functor/Of.hs

@@ -36,7 +36,7 @@ instance (Monoid a, Monoid b) => Monoid (Of a b) where
 instance Functor (Of a) where
   fmap f (a :> x) = a :> f x
   {-#INLINE fmap #-}
-  a <$ (b :> x)   = b :> a
+  a <$ (b :> _)   = b :> a
   {-#INLINE (<$) #-}
 
 #if MIN_VERSION_base(4,8,0)
@@ -52,19 +52,19 @@ instance Bifunctor Of where
 instance Monoid a => Applicative (Of a) where
   pure x = mempty :> x
   {-#INLINE pure #-}
-  m :> f <*> m' :> x = mappend m m' :> f x
+  (m :> f) <*> (m' :> x) = mappend m m' :> f x
   {-#INLINE (<*>) #-}
-  m :> x *> m' :> y  = mappend m m' :> y
+  (m :> _) *> (m' :> y)  = mappend m m' :> y
   {-#INLINE (*>) #-}
-  m :> x <* m' :> y  = mappend m m' :> x
+  (m :> x) <* (m' :> _)  = mappend m m' :> x
   {-#INLINE (<*) #-}
 
 instance Monoid a => Monad (Of a) where
-  return x = mempty :> x
+  return = pure
   {-#INLINE return #-}
-  m :> x >> m' :> y = mappend m m' :> y
+  (m :> _) >> (m' :> y) = mappend m m' :> y
   {-#INLINE (>>) #-}
-  m :> x >>= f = let m' :> y = f x in mappend m m' :> y
+  (m :> x) >>= f = let m' :> y = f x in mappend m m' :> y
   {-#INLINE (>>=) #-}
 
 #if MIN_VERSION_base(4,9,0)

src/Streaming.hs

@@ -1,6 +1,5 @@
 {-# LANGUAGE RankNTypes #-}
 
-{-# OPTIONS_GHC -Wall #-}
 module Streaming
    (
    -- * An iterable streaming monad transformer

src/Streaming/Internal.hs

@@ -6,10 +6,8 @@
 {-# LANGUAGE MultiParamTypeClasses #-}
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE ScopedTypeVariables #-}
-{-# LANGUAGE StandaloneDeriving #-}
 {-# LANGUAGE UndecidableInstances #-}
 
-{-# OPTIONS_GHC -Wall #-}
 module Streaming.Internal (
     -- * The free monad transformer
     -- $stream
@@ -1360,4 +1358,4 @@ cutoff = loop where
       e <- lift $ inspect str
       case e of
         Left r -> return (Just r)
-        Right (frest) -> Step $ fmap (loop (n-1)) frest
+        Right frest -> Step $ fmap (loop (n-1)) frest

src/Streaming/Prelude.hs

@@ -57,8 +57,6 @@
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TypeFamilies #-}
 
-{-# OPTIONS_GHC -Wall #-}
-
 module Streaming.Prelude (
     -- * Types
     Of (..)

streaming.cabal

@@ -192,6 +192,7 @@ homepage:            https://github.com/haskell-streaming/streaming
 bug-reports:         https://github.com/haskell-streaming/streaming/issues
 category:            Data, Pipes, Streaming
 extra-source-files:  README.md, changelog.md
+tested-with:         GHC ==7.10.3, GHC ==8.0.2, GHC ==8.2.2
 
 source-repository head
     type: git
@@ -203,16 +204,6 @@ library
     , Streaming.Prelude
     , Streaming.Internal
     , Data.Functor.Of
-  other-extensions:
-      RankNTypes
-    , CPP
-    , StandaloneDeriving
-    , FlexibleContexts
-    , DeriveDataTypeable
-    , DeriveFoldable
-    , DeriveFunctor
-    , DeriveTraversable
-    , UndecidableInstances
   build-depends:
       base >=4.8 && <5
     , mtl >=2.1 && <2.3
@@ -224,3 +215,11 @@ library
     , containers
   hs-source-dirs:    src
   default-language:  Haskell2010
+  ghc-options:
+    -Wall
+    -fwarn-name-shadowing
+  if impl(ghc >= 8.0)
+    ghc-options:
+      -Wincomplete-uni-patterns
+      -Wincomplete-record-updates
+      -Wcompat